Refactor redundant code into function

metabrainz · Jan 11, 2017 · 2ed88a8 · 2ed88a8
1 parent 99a7f5a
commit 2ed88a8
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/picard/ui/filebrowser.py b/picard/ui/filebrowser.py
@@ -129,21 +129,21 @@ def _restore_state(self):
             self.expand(index)
             self.scrollTo(index, scrolltype)
 
+    def _get_destination_from_path(self, path):
+        destination = os.path.normpath(unicode(path))
+        if not os.path.isdir(destination):
+            destination = os.path.dirname(destination)
+        return destination
+
     def move_files_here(self):
         indexes = self.selectedIndexes()
         if not indexes:
             return
         path = self.model.filePath(indexes[0])
-        destination = os.path.normpath(unicode(path))
-        if not os.path.isdir(destination):
-            destination = os.path.dirname(destination)
-        config.setting["move_files_to"] = destination
+        config.setting["move_files_to"] = self._get_destination_from_path(path)
 
     def set_as_starting_directory(self):
         indexes = self.selectedIndexes()
         if indexes:
             path = self.model.filePath(indexes[0])
-            destination = os.path.normpath(unicode(path))
-            if not os.path.isdir(destination):
-                destination = os.path.dirname(destination)
-            config.setting["starting_directory_path"] = destination
+            config.setting["starting_directory_path"] = self._get_destination_from_path(path)