Refactor code to allow duplicate removal

metabrainz · Jan 15, 2017 · e7d7ba8 · e7d7ba8
1 parent d3fcb3a
commit e7d7ba8
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/picard/ui/metadatabox.py b/picard/ui/metadatabox.py
@@ -331,11 +331,11 @@ def contextMenuEvent(self, event):
 
     def add_to_preserved_tags(self, name, preserved_tags):
         preserved_tags.append(name)
-        config.setting['preserved_tags'] = ", ".join((uniqify(preserved_tags)))
+        config.setting['preserved_tags'] = ", ".join(uniqify(preserved_tags))
 
     def remove_from_preserved_tags(self, name, preserved_tags):
-        preserved_tags.remove(name)
-        config.setting['preserved_tags'] = ", ".join((uniqify(preserved_tags)))
+        preserved_tags = filter(lambda x: x != name, preserved_tags)
+        config.setting['preserved_tags'] = ", ".join(uniqify(preserved_tags))
 
     def edit_tag(self, tag):
         EditTagDialog(self.parent, tag).exec_()