Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PICARD-1976: Fixed handling query args in CoverArtImage URLs #1661

Merged
merged 1 commit into from
Oct 17, 2020
Merged

PICARD-1976: Fixed handling query args in CoverArtImage URLs #1661

merged 1 commit into from
Oct 17, 2020

Conversation

phw
Copy link
Member

@phw phw commented Oct 17, 2020

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Loading cover art images from URLs with query arguments (such as e.g. https://api.deezer.com/album/393516/image?size=big) fails because the query arguments do not get passed properly to the webservice module.

Problem

Solution

Properly handle parse the query arguments and use them in the ws request.

@phw phw requested a review from zas October 17, 2020 09:59
zas
zas approved these changes Oct 17, 2020
View reviewed changes
Copy link
Collaborator

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phw phw merged commit 09a4a4f into metabrainz:master Oct 17, 2020
@phw phw deleted the PICARD-1976-fix-coverart-url-query-args branch October 17, 2020 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zas zas zas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phw @zas