CI: Install gettext for Windows #2371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before that the gettext command shipping with git for Windows were used. Since git 2.44.0 these are no longer bundled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
On Github action the provided gettext tools (in particular
msgfmtwhere gettext commands shipping with git for Window. Since git 2.44.0 these are no longer bundled and hence the builds started failing.Fix this by explicitly downloading and installing gettext for Windows.
Unfortunalety there are no official binary packages and many binary packages offered online are outdated. In particular there are no recent gettext packages available for automatic installation via Win-Get or chocolatey.
But https://github.com/vslavik/gettext-tools-windows is maintained by the Poedit author and provides up-to-date packages. Hence this PR downloads the latest release from there and unzips it locally.