Ignore special tracks for completeness #383
Conversation
Fixes PICARD-652
…eness. Currently this will ignore video, pregap, data and silent tracks. Fixes PICARD-514
Works currently only for renaming scripts (similar to $matchedtracks). PICARD-514
…ctly under the input fields. This was accidentally moved when adding new fields to this options page.
|
Another issue is the wording in the options dialog. Currently it reads "Ignore the following tracks for release completeness". Is this proper English and is it clear what it means? |
|
This is also related to PICARD-185, but does not solve the main issue there (ignoring data tracks for numbering). I could extend this patch to also have ignored track types not to be used for the numbering, but I'd prefer this to be done in a separate PR after this one has been merged. |
|
I would probably say "when determining whether a release is complete" rather than "for release completeness", or at least "when determining release completeness" if nothing else. What you have doesn't sound wrong, as such, I just think it's not necessarily very clear if you don't already know what it's referring to. Could you take a screenshot of how it looks with the icons? |
|
@96187 Thanks for the feedback. Here is a screenshot of how the icons look like. This also shows that in this case the data tracks are ignored when determining whether a release is complete, but not the pre-gap track (but it could be).
The following screenshot shows the options screen:
|
|
Thanks for the screenshot. :) The cog icon looks weird to me, I would use a file icon of some sort, because data tracks which aren't videos are mostly going to be things like MP3 files, so a cog doesn't have any obvious connection. The video icon doesn't look too bad to me, although it might blend in better if it used the same colours as the music note, which might be simple enough to do? |
|
The code looks good to me, but I'm not going to be of any help with graphics stuff :p |
|
What about something like : |
| @@ -602,6 +602,13 @@ def func_matchedtracks(parser, arg): | |||
| return "0" | |||
|
|
|||
|
|
|||
| def func_is_complete(parser): | |||
| if parser.file: | |||
| if parser.file.parent and parser.file.parent.album.is_complete(): | |||
There was a problem hiding this comment.
A single if + and would be enough here
|
Overall the patch is ok for me, nice addition imho. |
|
Ok, I will take all your feedback into consideration and update this PR (I hope sometime before the holidays). |
|
I have played with the icons, please give me some feedback. New icons, less colorful: Only the data icon track replaced: For comparisson the old screenshot from above: |
Icons use symbols from Font Awesome by Dave Gandy - http://fontawesome.io
|
I like those in
|
|
@phw : i'm ok to merge it once you'll addressed following comments |
|
@zas: I've updated the code |
|
We still need more feedback about new icons, but for me it is ready for merge. |
|
I prefer the black and white icons in isolation, but dunno how well they work with the rest of the interface. Any of the two options is an improvement though, so both seem good enough. |
|
Just because I didn't say this: The black icons are also what is currently in this PR as they are the ones I prefer, too :) |
|
The black-and-white don't seem to match the style of the rest of the interface to me, especially the disc icon, or if not changed the unmatched file icon which currently uses the color notes. A mix of flat and 3D icons seems weird, not to mention a mix of color and non-color, and the black-and-white/flat looks very pre-internet-age-style, or something, to me. The video one maybe contributes to that since really, nobody's using this to print labels for film canisters (and the screen icon matches what's used on mb.org better as well, which may or may not be a goal). So I'd vote for the newer color icons, perhaps ideally with a less flat "binary written on paper" type icon. I do think that's better than the cog for denoting data track, though. For consideration/comparison, mb.org uses this for data tracks: |
|
+1 to what @ianmcorvidae said. |
|
I see the issues you have with the flat icons. Well, actually not all :) I don't think these icons look "pre-internet-age-style", rather they are the current popular icon style on many web pages. The colored Tango icons Picard uses are so 90s :P But the real reason I wanted to try those is that they remove visual clutter from the listings and make the main information stand out more while still providing a clear distinction for the track types. Anyway, when using the data icon from MB this looks like this:
This is probably the version most consistent with both Picards original style and the MB website. I have not pushed those changes yet, but if feedback is positive I will push it and merge this PR. |
|
I'd maybe support the black-and-white if they were greys rather than pure black-and-white; that's really the thing that makes it feel like I'm looking at Windows 3.1 to me :) In any case, I like the version with the data track icon from the site if others are fine with that. Perhaps we can move to a flatter icon style in another PR if that's desired, and keep it consistent here. |
|
I agree with what reosarevok said. I like the black and white icons, at least in the screenshots here. Having black and white base icons also leaves open the possibility of adding coloured variants for things like matched tracks, tracks with errors, etc in the future (probably with ticks or exclamation marks so that it's not just colour). The only icon I really didn't like though was the cog. |
Good point. It may be useful in the future.
Windows 3.1 had colorful icons. |
Ignore special tracks for completeness
|
Since the consensus seems to be, that the colored icons are ok and more consistent with current Picard, but the flat icons might be nice to reconsider later, I have merged this PR together with the colored icons. The flat icons are still in the commit history, so if somebody wants to build on this please do. |
This adds an option to ignore some track types for determining the completeness of an album. This makes it easier for a user to see completed albums and ignore tracks she doesn't care about. Currently the user can choose to ignore:
In addition this PR adds some more changes to simplify the work with those tracks:
$is_complete()tagger script function~videotagger script variable for video tracksThis PR will fix PICARD-514 and PICARD-652
This PR is not ready for merging due to the new icons. I have added icons from the Tango icon set for the track types because this is the icon set the current note icon is taken from. But I think the icons are a) really ugly and b) make the UI way too noisy. But since I am not very talented in designing icons and I am not sure when I will find the time to look for nicer icons with an acceptable license I just publish the code here and ask you all for help :)
Some notes about the
$is_complete()function: This is somewhat similar to the$isperfectalbumfunction @Sophist-UK proposed in PICARD-637. But I deliberately decided not to add the special logic of having only one matched file per track. I think this is a different change which should be discussed separately. For me it was important that$is_complete()and the visual representation of the completeness are identical.