-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Year in music and a whole pile of other general development #41
Conversation
…layground into year-review
…year you've listened to.
…on-playground into year-review
… be consistent and sensical
This comment has been minimized.
This comment has been minimized.
into the pipeline which prints the list and passes it on
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
typechecking for operation elements that specify no types
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments. otherwise LGTM. More docs and test will also help but we already decided to do that in follow up PR so that is fine.
This comment has been minimized.
This comment has been minimized.
Unit Test Results 1 files ±0 1 suites ±0 0s ⏱️ ±0s For more details on these failures, see this check. Results for commit a50d2e2. ± Comparison against base commit a50d2e2. |
This PR is too large and I apologize for that. It originally started off for the 2020 year in review work, but then languished until now. And in creating the playlist for this years year review, I needed to create many more elements in order to get the job accomplished.
Some of the work in this PR:
This PR does not address tests -- that will come in the next version. But lets aim to merge this ASAP so that it does not continue to get bigger.