Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Year in music and a whole pile of other general development #41

Merged
merged 35 commits into from
Dec 2, 2021

Conversation

mayhem
Copy link
Member

@mayhem mayhem commented Dec 1, 2021

This PR is too large and I apologize for that. It originally started off for the 2020 year in review work, but then languished until now. And in creating the playlist for this years year review, I needed to create many more elements in order to get the job accomplished.

Some of the work in this PR:

  • Create top discoveries patch
  • Create top recordings patch
  • Create top missed recordings
  • Add BPM lookup element
  • Add Mood lookup element
  • Add playlist shaper that orders a playlist by BPM, from low to high to low again.
  • Add a playlist shuffle element
  • Add a playlist redundancy reducer element
  • Add a playlist duplicate reducer that removes duplicates based on artist/track name for use with Annoy
  • Add type checking of the pipeline so that input/output mismatching pipelines cannot be created.
  • Add command line support to override playlist name/desc
  • Add a patch to read a file with MBIDs and make a playlist from them.

This PR does not address tests -- that will come in the next version. But lets aim to merge this ASAP so that it does not continue to get bigger.

@github-actions

This comment has been minimized.

into the pipeline which prints the list and passes it on
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

typechecking for operation elements that specify no types
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@mayhem mayhem marked this pull request as ready for review December 2, 2021 13:11
@mayhem mayhem requested a review from amCap1712 December 2, 2021 13:11
Copy link
Member

@amCap1712 amCap1712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments. otherwise LGTM. More docs and test will also help but we already decided to do that in follow up PR so that is fine.

troi/print_recording.py Show resolved Hide resolved
troi/acousticbrainz/mood_lookup.py Outdated Show resolved Hide resolved
troi/cli.py Outdated Show resolved Hide resolved
troi/patches/ab_similar_recordings.py Show resolved Hide resolved
troi/playlist.py Show resolved Hide resolved
troi/playlist.py Outdated Show resolved Hide resolved
troi/patches/world_trip.py Outdated Show resolved Hide resolved
troi/patches/world_trip.py Outdated Show resolved Hide resolved
@mayhem mayhem merged commit a50d2e2 into main Dec 2, 2021
@mayhem mayhem deleted the year-review branch December 2, 2021 14:46
@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Dec 2, 2021

Unit Test Results

  1 files  ±0    1 suites  ±0   0s ⏱️ ±0s
36 tests ±0  32 ✔️ ±0  0 💤 ±0  4 ❌ ±0 

For more details on these failures, see this check.

Results for commit a50d2e2. ± Comparison against base commit a50d2e2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants