Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude inc and local directories from indexing #367

Merged
merged 1 commit into from
Dec 9, 2014

Conversation

rose
Copy link
Contributor

@rose rose commented Dec 9, 2014

@oalders
Copy link
Member

oalders commented Dec 9, 2014

Looks like it's just the tidy test that failed.

@rose
Copy link
Contributor Author

rose commented Dec 9, 2014

I ran tidyall on both files before submitting, and the tests all pass on my machine. I don't have any uncommitted changes. Could the test server have a different tidyall configuration or something?

@rose
Copy link
Contributor Author

rose commented Dec 9, 2014

I ran tidyall on File.pm again and it didn't make any changes. Is there a way to see what line(s) travis is failing on?

@oalders
Copy link
Member

oalders commented Dec 9, 2014

Weird.

~/Documents/github/metacpan-developer/src/metacpan-api ∙ tidyall lib/MetaCPAN/Document/File.pm
[tidied]  lib/MetaCPAN/Document/File.pm
❤ ★         ✎       (heads/pr/367)
~/Documents/github/metacpan-developer/src/metacpan-api ∙ git diff
diff --git a/lib/MetaCPAN/Document/File.pm b/lib/MetaCPAN/Document/File.pm
index bc44c58..b8dc2e3 100644
--- a/lib/MetaCPAN/Document/File.pm
+++ b/lib/MetaCPAN/Document/File.pm
@@ -627,7 +627,7 @@ sub is_in_excluded_directory {
     my @parts    = split m{/}, $self->path;
     return any {
         my $part = $_;
-        any { $_ eq $part } @excluded
+        any { $_ eq $part } @excluded;
     }
     @parts;
 }

@rose
Copy link
Contributor Author

rose commented Dec 9, 2014

yeah, tidyall on my vagrant box is definitely not asking for that change. Any ideas on what might be different? Could I have a config file or module that's out of date and not being updated when I reprovision the machine?

@oalders
Copy link
Member

oalders commented Dec 9, 2014

Possibly you've got a different version of Perl::Tidy. What do you have?

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7a3bea6 on rose:excludePaths into * on CPAN-API:master*.

@rose
Copy link
Contributor Author

rose commented Dec 9, 2014

WHO'S YOUR DADDY TRAVIS

@oalders
Copy link
Member

oalders commented Dec 9, 2014

\o/

oalders added a commit that referenced this pull request Dec 9, 2014
exclude inc and local directories from indexing
@oalders oalders merged commit c40d9aa into metacpan:master Dec 9, 2014
@haarg haarg removed the in progress label Dec 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modules are being found, and indexed in search, in a distribution's local/ directory
4 participants