Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] created new endpoints to remove web ES awareness #530

Closed
wants to merge 31 commits into from
Closed

[WIP] created new endpoints to remove web ES awareness #530

wants to merge 31 commits into from

Conversation

mickeyn
Copy link
Contributor

@mickeyn mickeyn commented Sep 27, 2016

as discussed before, i'd like to start moving some ES queries done in metacpan-web to the API as new endpoints.

the idea is to hide the storage behind the API and allow consolidation of functionality between all API using tools (web, client, etc.)

this is just a first step (out of many) so the PR is mostly for the welcomed discussion.

@coveralls
Copy link

Coverage Status

Coverage decreased (-23.6%) to 66.52% when pulling ed082c6 on mickey/wip_new_endpoints into 05ec1e0 on master.

@mickeyn mickeyn mentioned this pull request Sep 28, 2016
Closed
@mickeyn mickeyn force-pushed the mickey/wip_new_endpoints branch 8 times, most recently from ad10ae2 to 609bf30 Compare September 29, 2016 13:53
@coveralls
Copy link

Coverage Status

Coverage decreased (-12.4%) to 77.677% when pulling 609bf30 on mickey/wip_new_endpoints into ba9cab4 on master.

oalders
oalders reviewed Sep 29, 2016
View reviewed changes
lib/MetaCPAN/Server/Controller/Author.pm
my ( $self, $c ) = @_;
my @users = split /,/ => $c->req->parameters->{users};
$self->es_query_by_key( $c, 'user', \@users );
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a role? It looks to be identical in two of these packages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slowly getting there :)

@mickeyn mickeyn changed the title [WIP] created /author/by_user endpoint to replace web direct query created /author/by_user endpoint to replace web direct query Nov 17, 2016
@mickeyn mickeyn changed the title created /author/by_user endpoint to replace web direct query [WIP] created /author/by_user endpoint to replace web direct query Nov 17, 2016
@mickeyn mickeyn force-pushed the mickey/wip_new_endpoints branch 3 times, most recently from 0ffc711 to dcb7652 Compare November 20, 2016 21:25
@mickeyn mickeyn changed the title [WIP] created /author/by_user endpoint to replace web direct query [WIP] created new endpoints to replace web ES awareness Nov 23, 2016
@mickeyn mickeyn changed the title [WIP] created new endpoints to replace web ES awareness [WIP] created new endpoints to remove web ES awareness Nov 23, 2016
@coveralls
Copy link

coveralls commented Nov 23, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 74.121% when pulling f1e8a04 on mickey/wip_new_endpoints into d174bff on master.

@coveralls
Copy link

coveralls commented Nov 24, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 74.121% when pulling 895bf7b on mickey/wip_new_endpoints into d174bff on master.

@coveralls
Copy link

coveralls commented Nov 25, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 74.121% when pulling 56283c0 on mickey/wip_new_endpoints into d174bff on master.

@coveralls
Copy link

coveralls commented Nov 25, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 74.121% when pulling 523d852 on mickey/wip_new_endpoints into d174bff on master.

@coveralls
Copy link

coveralls commented Nov 25, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 74.121% when pulling 523d852 on mickey/wip_new_endpoints into d174bff on master.

@mickeyn
Copy link
Contributor Author

mickeyn commented Jun 9, 2017

most of this is currently happening in small chunks, closing the PR

@mickeyn mickeyn closed this Jun 9, 2017
@mickeyn mickeyn deleted the mickey/wip_new_endpoints branch June 22, 2017 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oalders oalders oalders left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mickeyn @coveralls @oalders