Fix the module search #1804
Merged
Fix the module search #1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The page size shouldn't dynamically scale without the starting point of each page also scaling in step. Otherwise, the pages ending up overlapping once $run is >1. This is the simpler fix. A slightly more complicated fix would be adjusting "from" instead to scale in step, but that seems unnecessary.
Requesting a field more than once produces the value more than once which causes the new ES to produce an array value for the field containing duplicate values. This busts our collapsed search which ended up making ref addresses unique instead of distribution names. With the root cause removed, the map which papered over the symptoms is not longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.