Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the module search #1804

Merged
merged 2 commits into from Nov 19, 2016
Merged

Fix the module search #1804

merged 2 commits into from Nov 19, 2016

Commits on Nov 19, 2016

  1. Module search: Page correctly when fetching unique distributions 

    The page size shouldn't dynamically scale without the starting point of
each page also scaling in step.  Otherwise, the pages ending up
overlapping once $run is >1.

This is the simpler fix.  A slightly more complicated fix would be
adjusting "from" instead to scale in step, but that seems unnecessary.
    @tsibley
    tsibley committed Nov 19, 2016
    Configuration menu
    Copy the full SHA
    7d41a31 View commit details
    Browse the repository at this point in the history

  2. Module search: Avoid requesting duplicate fields from ES 

    Requesting a field more than once produces the value more than once
which causes the new ES to produce an array value for the field
containing duplicate values.  This busts our collapsed search which
ended up making ref addresses unique instead of distribution names.
With the root cause removed, the map which papered over the symptoms is
not longer needed.
    @tsibley
    tsibley committed Nov 19, 2016
    Configuration menu
    Copy the full SHA
    efc55a2 View commit details
    Browse the repository at this point in the history