-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use grep metacpan for distro search #1991
Conversation
root/inc/release-tools.html
Outdated
@@ -35,8 +35,9 @@ | |||
</button> | |||
</li> | |||
<li> | |||
<form action="/search"> | |||
<input type="hidden" name="q" value="dist:<% release.distribution %>"> | |||
<form action="http://grep.metacpan.org/search"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be https.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated to https, was not sure it was available :-)
c0c4ad8
to
a69639e
Compare
My concern here is that this may end up being confusing for users. To start with, I think I'd prefer having a search in dist + a grep in dist link. There's room for it in the UI. The grep link could use the magnifying glass icon to make it consistent. Consider (bad example) some search like https://metacpan.org/search?q=dist:DateTime-Format-MySQL+datetime%20format%20mysql Inside the dist, it returns at least one useful result. On the grep app, it will return nothing (if I got the query correct): https://grep.metacpan.org/search?q=datetime+format+mysql&qd=DateTime-Format-MySQL&qft= So, I think that a full text search won't always translate well to a grep. It would be nice to have both options at least to start with and people could let us know if we should drop the old one or continue on with it. |
thanks for the feedback, I will adjust the [minor] changes in that direction |
a69639e
to
0deb4da
Compare
@oalders I've updated the PR as suggested. But I've discarded adding the fa search icon to the placeholder, as this requires changing the font-family for this input search and looks awkward when compare side/side |
Could you rebase this branch and also change |
Provide an alternate search option from the left menu bar, to use grep.metacpan. note that grep.metacpan is only going to perform the search for the last available version of the distribution.
0deb4da
to
6e2b555
Compare
@oalders rebased and change |
Thanks! Build failure is unrelated. |
note that grep.metacpan is only going to perform
the search for the last available version of
the distribution.