rewrite changes handling for rss feed #2857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oalders
requested changes
Jan 9, 2023
The previous code would batch requests in the controller, manually generate URLs in the model, and had odd inputs and outputs. Rewrite the changes model by_release method to accept a simple list of release paths, handling batching internally, and return a simple hashref. Doing the batching internally makes it easy to add concurrency to the requests. Also fix the version regex to understand v prefixes.
haarg
force-pushed
the
haarg/rewrite-feed-changes-fetch
branch
from
1a7d5e9
to
bbc3f80
Compare
oalders
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code would batch requests in the controller, manually generate URLs in the model, and had odd inputs and outputs.
Rewrite the changes model by_release method to accept a simple list of release paths, handling batching internally, and return a simple hashref. Doing the batching internally makes it easy to add concurrency to the requests.
Also fix the version regex to understand v prefixes.