forked from rebolsource/r3
-
Notifications
You must be signed in to change notification settings - Fork 27
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Disallow testing for IS_TRASH in release builds
The idea of a "trash" cell is that debug builds can protect against reading such cells before they are filled with meaningful data. But unlike an ordinary uninitialized cell, these trash cells are ignored by the garbage collector...so they can sit in arrays spanning evaluations. There was a misguided idea that IS_TRASH() in a release build was defined to false, based on the concept that no such cells would exist. This broke a case in the APPLY implementation where the trash state was being used to carry meaning...because in the release build initializing a cell to trash and then asking if it was trash would return false. The correct way to avoid this problem is to not define IS_TRASH() in the release build to catch such incorrect uses. APPLY was changed to use a NONE state for the signal, as it needed a signal that could be read as well as written.
- Loading branch information
1 parent
2ec7bd7
commit 5ab7367
Showing
4 changed files
with
13 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters