Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce encode-csv #483

Closed
TobiasNx opened this issue May 8, 2023 · 3 comments
Closed

Introduce encode-csv #483

TobiasNx opened this issue May 8, 2023 · 3 comments
Assignees
@TobiasNx

Comments

@TobiasNx
Copy link
Contributor

TobiasNx commented May 8, 2023 •
edited by dr0i
Loading

We can decode csv with metafacture but we cannot encode it.
Would be nice to have an encoder for csv

We can reuse the csv-plugin: https://github.com/metafacture/metafacture-csv-plugin
@dr0i dr0i self-assigned this May 8, 2023
@TobiasNx
Copy link
Contributor Author

Usecase scenario: transforming metadata into KBART-format which has a tsv-serialation.

dr0i added a commit that referenced this issue May 19, 2023
@dr0i
Add CsvEncoder (#483)
3a8c225
@dr0i dr0i mentioned this issue May 19, 2023
Merged
@dr0i dr0i assigned TobiasNx and unassigned dr0i May 19, 2023
dr0i added a commit that referenced this issue May 20, 2023
@dr0i
Add CsvEncoder (#483)
a5549dd 
Copied from https://github.com/metafacture/metafacture-csv-plugin.
Original author: eberhardtj (j.eberhardt@dnb.de).
dr0i added a commit that referenced this issue May 20, 2023
@dr0i
Use stream test; format (#483)
96605ab
dr0i added a commit that referenced this issue May 22, 2023
@dr0i
Use MockitoRule instead of @before setup (#483)
67b4412 
Based on a suggestion by Jens Wille.
@dr0i
Copy link
Member

dr0i commented May 22, 2023

from #486 (comment):

I tested without options and | encode-csv(includeHeader="TRUE", separator="\t", noQuotes="true") seem to work nicely!

Also added to flux-commands.

@dr0i dr0i mentioned this issue May 22, 2023
Closed
@dr0i
Copy link
Member

dr0i commented Jun 2, 2023

Solved. Closing.

@dr0i dr0i closed this as completed Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TobiasNx TobiasNx

Labels
None yet
Projects
Metafacture
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dr0i @TobiasNx