Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JSON schema validator #468

Merged
merged 9 commits into from Feb 16, 2023
Merged

Add JSON schema validator #468

merged 9 commits into from Feb 16, 2023

Conversation

fsteeg
Copy link
Member

@fsteeg fsteeg commented Sep 20, 2022

Originally developed in OERSI.

Will resolve #443.

@fsteeg fsteeg mentioned this pull request Sep 20, 2022
Closed
@blackwinter blackwinter assigned fsteeg and unassigned blackwinter Sep 20, 2022
@fsteeg
Copy link
Member Author

fsteeg commented Sep 22, 2022

Thanks for the review. I agree and addressed your points in the commits above (did you think of backticks/code formatting in the Markdown comment?).

@fsteeg fsteeg assigned blackwinter and unassigned fsteeg Sep 22, 2022
blackwinter
blackwinter approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@blackwinter blackwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Two minor points left, but overall 👍

did you think of backticks/code formatting in the Markdown comment?

Yes, that's what I meant.

metafacture-json/src/main/java/org/metafacture/json/JsonValidator.java Outdated Show resolved Hide resolved
metafacture-json/src/main/java/org/metafacture/json/JsonValidator.java Show resolved Hide resolved
@blackwinter blackwinter assigned fsteeg and unassigned blackwinter Sep 22, 2022
@fsteeg
Copy link
Member Author

fsteeg commented Sep 22, 2022

Thanks! Addressed the two points in 43989af. Will merge after functional review of #443.

@fsteeg
Copy link
Member Author

fsteeg commented Sep 29, 2022

Marking as draft, needs URL support for the main schema. See #443 (comment).

@fsteeg fsteeg marked this pull request as draft September 29, 2022 09:35
@fsteeg fsteeg marked this pull request as ready for review February 2, 2023 09:20
@fsteeg
Copy link
Member Author

fsteeg commented Feb 2, 2023

See #443 (comment) for a summary of the new changes.

@fsteeg fsteeg assigned blackwinter and unassigned fsteeg Feb 2, 2023
@blackwinter blackwinter removed their assignment Feb 2, 2023
@fsteeg fsteeg removed their assignment Feb 9, 2023
@fsteeg fsteeg merged commit 8a3e605 into master Feb 16, 2023
@fsteeg fsteeg deleted the 443-jsonValidator branch February 16, 2023 09:43
@blackwinter blackwinter mentioned this pull request May 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blackwinter blackwinter blackwinter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON-Schema-Validator Modul compatible at least with JSON-Schema v7
2 participants
@fsteeg @blackwinter