Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asNavFor mirror groupCell of it's parent #419

Closed
amdad opened this issue Jul 21, 2016 · 3 comments
Closed

asNavFor mirror groupCell of it's parent #419

amdad opened this issue Jul 21, 2016 · 3 comments
Labels

Comments

@amdad
Copy link

amdad commented Jul 21, 2016

Hey David! @desandro
Thanks for greatly awaited groupCell. Works flawless.

I tried to use it with David asNavFor and here is my feature request.

I used main flickity with auto groupCell, so it changes dynamically number of is-selected (in viewarea) cells. And here is a problem. Navigation is-selected cells are not "chained" with those in main carousel. I know it have separate settings but none of them mirror parent carousel.

I don't want to change how navigation works. Because it's OK (my settings below). I just want to have is-selected active classes in nav to exactly highlight the same cells as it's target carousel. Already (in my settings) only one cell is-selected, I don't think it should be hard to add. Am I wrong?

This is cosmetic thing just for highlight/tell user which cells are already displayed so they are no longer active as links to move forward/backward. Because number of slides according to them widths and viewarea are dynamic, so none of current "nav" settings match this goal.

      prevNextButtons: false,
      pageDots: false,
      margin: 5,
      asNavFor: '.carousel',
      wrapAround: true, 
      cellAlign: 'center',
      lazyLoad: 8,
      freeScroll: true 
desandro added a commit to metafizzy/flickity-as-nav-for that referenced this issue Jul 21, 2016
+ select center cell when grouped
+ fix AMD definition

Ref metafizzy/flickity#419
@desandro
Copy link
Member

Thank you for reporting this issue. I've fixed this behavior in flickity-as-nav-for. This will be fixed in the next release.

@amdad
Copy link
Author

amdad commented Jul 22, 2016

Wahoo! Thanks David!

@desandro desandro added the bug label Jul 29, 2016
@amdad
Copy link
Author

amdad commented Aug 20, 2016

Included in 2.0.3!

@amdad amdad closed this as completed Aug 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants