Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Giving user option to generate ICS / add events / delete events within gyft.py #96

Merged
merged 11 commits into from Aug 12, 2023

Conversation

ashwinpra
Copy link
Member

With reference to #91

  • Modularised the whole code and made it cleaner
  • Now, instead of user having to execute generate_ics.py separately, the generate_ICS() function is executed directly in gyft.py based on user input
  • Earlier, the --input (name of input .txt file) and --output(name of output .ics file) arguments taken by generate_ics.py is now taken by gyft.py directly
  • Here is the current workflow:
    • Checks if input .txt file exists. If yes, ask user whether they want to overwrite it
    • If it doesn't exist, or user asks to overwrite, timetable is fetched and saved to the .txt file
    • Asks user whether they want to generate .ics file. If yes, generate it using generate_ICS()

If these changes are fine, I will update the README correspondingly, and also work on adding the functionalities of add_events.py and delete_events.py as well.

proffapt

This comment was marked as resolved.

proffapt

This comment was marked as resolved.

@ashwinpra
Copy link
Member Author

Now for the biggest task - updating the docs (=____=)

@ashwinpra ashwinpra changed the title Giving user option to generate ICS within gyft.py Giving user option to generate ICS / add events / delete events within gyft.py Aug 12, 2023
@proffapt
Copy link
Member

Now for the biggest task - updating the docs (=____=)

Ig lets do it in separate PR after this, it already has a an issue #93
You can implement those points in multiple PRs if need (talking about video, can do that later)

proffapt

This comment was marked as resolved.

ashwinpra and others added 2 commits August 12, 2023 12:38
Co-authored-by: Arpit Bhardwaj <proffapt@pm.me>
gyft.py Outdated Show resolved Hide resolved
Co-authored-by: Arpit Bhardwaj <proffapt@pm.me>
generate_ics.py Outdated Show resolved Hide resolved
Copy link
Member

@proffapt proffapt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jai ho ashwin baba ki :orz:

@proffapt proffapt merged commit 2a7715f into metakgp:master Aug 12, 2023
@proffapt proffapt mentioned this pull request Aug 12, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants