-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added configuration for Slow query log #94
Conversation
Please review @thealphadollar @icyflame . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @grapheo12 for investing time in improving the wiki, it means a lot especially when you have a lot of stuff (CDC, registration, projects, etc.) you are busy in.
The PR looks super cool ✨
7688a4a
to
7d6069a
Compare
7d6069a
to
a3edda9
Compare
@icyflame @amrav Can you please find sometime to review this PR again, @grapheo12 has implemented the requested changes. Only once you give your nod, we will deploy this. |
@icyflame Thanks for your review :D I came across #73. Do you think we should incorporate the same in this PR as it also concerns the configuration? cc/ @grapheo12 |
LGTM :)
Please interpret approval + comments as good to merge after addressing
comments (ie don't wait for reapproval from me). Also would suggest merging
as-is and opening another PR if you want to make further changes, rather
than keeping this PR open for more than a few days.
…On Sun, Aug 23, 2020 at 3:35 PM Shivam Kumar Jha ***@***.***> wrote:
@icyflame <https://github.com/icyflame> Thanks for your review :D
I came across #73 <#73>. Do
you think we should incorporate the same in this PR as it also concerns the
configuration?
cc/ @grapheo12 <https://github.com/grapheo12>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#94 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJBT75NCTRCNTYTUN74A53SCESK3ANCNFSM4PZOM75Q>
.
|
Followed this: https://gist.github.com/akirattii/40b284332e887f2f3dcdc4bca08517a5
Tested that the
slow.log
appears at/var/log/mysql/
inside the image.