Added configuration for Slow query log #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review @thealphadollar @icyflame . |
amrav
reviewed
Aug 10, 2020
amrav
approved these changes
Aug 10, 2020
thealphadollar
approved these changes
Aug 10, 2020
There was a problem hiding this comment.
Thanks a lot @grapheo12 for investing time in improving the wiki, it means a lot especially when you have a lot of stuff (CDC, registration, projects, etc.) you are busy in.
The PR looks super cool ✨
icyflame
reviewed
Aug 11, 2020
grapheo12
force-pushed
the
mysql-slow-log
branch
from
7688a4a
to
7d6069a
Compare
grapheo12
force-pushed
the
mysql-slow-log
branch
from
7d6069a
to
a3edda9
Compare
|
@icyflame @amrav Can you please find sometime to review this PR again, @grapheo12 has implemented the requested changes. Only once you give your nod, we will deploy this. |
icyflame
approved these changes
Aug 23, 2020
|
@icyflame Thanks for your review :D I came across #73. Do you think we should incorporate the same in this PR as it also concerns the configuration? cc/ @grapheo12 |
|
LGTM :)
Please interpret approval + comments as good to merge after addressing
comments (ie don't wait for reapproval from me). Also would suggest merging
as-is and opening another PR if you want to make further changes, rather
than keeping this PR open for more than a few days.
…On Sun, Aug 23, 2020 at 3:35 PM Shivam Kumar Jha ***@***.***> wrote:
@icyflame <https://github.com/icyflame> Thanks for your review :D
I came across #73 <#73>. Do
you think we should incorporate the same in this PR as it also concerns the
configuration?
cc/ @grapheo12 <https://github.com/grapheo12>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#94 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJBT75NCTRCNTYTUN74A53SCESK3ANCNFSM4PZOM75Q>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followed this: https://gist.github.com/akirattii/40b284332e887f2f3dcdc4bca08517a5
Tested that the
slow.logappears at/var/log/mysql/inside the image.