Enable retrieving existing Prefix CIDRs from the Ipamer #69
Conversation
|
Can you please add a small test, otherwise this looks fine. |
|
Added a test for all data sources |
ipam.go
Outdated
| @@ -32,6 +32,8 @@ type Ipamer interface { | |||
| // PrefixesOverlapping will check if one ore more prefix of newPrefixes is overlapping | |||
| // with one of existingPrefixes | |||
| PrefixesOverlapping(existingPrefixes []string, newPrefixes []string) error | |||
| // Retrieve all existing Prefix CIDRs from the underlying storage | |||
There was a problem hiding this comment.
go doc should start with:
// ReadAllPrefixCidrs
prefix.go
Outdated
| @@ -484,6 +484,11 @@ func (i *ipamer) newPrefix(cidr, parentCidr string) (*Prefix, error) { | |||
| return p, nil | |||
| } | |||
|
|
|||
| // Retrieve all existing Prefix CIDRs from the underlying storage | |||
There was a problem hiding this comment.
Sorry about that, forgot it was in two places. Should be all good now
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
+ Coverage 78.12% 78.19% +0.06%
==========================================
Files 7 7
Lines 640 642 +2
==========================================
+ Hits 500 502 +2
Misses 75 75
Partials 65 65
Continue to review full report at Codecov.
|
|
Fixed. |
Discussion can be found here: #68