Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding mongodb storage backend #80

Merged
merged 6 commits into from
Jul 20, 2022
Merged

Conversation

f00actual
Copy link
Contributor

adding mongodb storage backend

closes #79

@majst01
Copy link
Contributor

majst01 commented Jul 18, 2022

Nice so far, please check the output of golangci-lint run -p bugs -p unused

testing_test.go Outdated Show resolved Hide resolved
@majst01
Copy link
Contributor

majst01 commented Jul 18, 2022

Can you please add some useful entries to the Readme as well, especially the table with the supported mongodb versions and some "normalized" benchmark numbers. According to the ci run the benchmark shows a ~ 2x performance of the postgres version.

@f00actual
Copy link
Contributor Author

What approach did you take for the op/sec normalization in the README.md? It appears the latest bench results ran on different hardware and they might need updated overall. What do you think?

@majst01
Copy link
Contributor

majst01 commented Jul 19, 2022

What approach did you take for the op/sec normalization in the README.md? It appears the latest bench results ran on different hardware and they might need updated overall. What do you think?

Like your current layout, but the problem persist, these hardware specs are hard to achieve. And what is actually running in the ci pipeline is not known.

@codecov-commenter
Copy link

Codecov Report

Merging #80 (d337d10) into master (10374d8) will decrease coverage by 1.62%.
The diff coverage is 63.55%.

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   75.84%   74.22%   -1.63%     
==========================================
  Files           8        9       +1     
  Lines         828      935     +107     
==========================================
+ Hits          628      694      +66     
- Misses        109      131      +22     
- Partials       91      110      +19     
Impacted Files Coverage Δ
mongodb.go 63.55% <63.55%> (ø)
memory.go 93.10% <0.00%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10374d8...d337d10. Read the comment docs.

@majst01
Copy link
Contributor

majst01 commented Jul 19, 2022

I think this is ready for merging, please mark it as ready for review.

@f00actual f00actual marked this pull request as ready for review July 19, 2022 16:11
@f00actual f00actual requested a review from a team as a code owner July 19, 2022 16:11
@majst01 majst01 merged commit aec17c3 into metal-stack:master Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mongodb storage backend
3 participants