Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netaddr is deprecated in favour of netip/netipx #88

Merged
merged 7 commits into from
Sep 14, 2022

Conversation

majst01
Copy link
Contributor

@majst01 majst01 commented Sep 4, 2022

https://github.com/inetaf/netaddr is set to readonly because the .af subdomain is controlled by Taliban.

The replacement is go4.org/netipx which also uses net/netip as a base.

BTW: headscale and tailscale do not depend on inet.af/netaddr anymore

@majst01 majst01 requested a review from a team as a code owner September 4, 2022 13:02
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2022

Codecov Report

Merging #88 (24d2c6b) into master (1d3698a) will increase coverage by 0.32%.
The diff coverage is 97.36%.

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   70.64%   70.96%   +0.32%     
==========================================
  Files          10       10              
  Lines        1107     1109       +2     
==========================================
+ Hits          782      787       +5     
+ Misses        207      203       -4     
- Partials      118      119       +1     
Impacted Files Coverage Δ
prefix.go 79.34% <97.29%> (+0.86%) ⬆️
pkg/service/ipam-service.go 54.32% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@GrigoriyMikhalkin GrigoriyMikhalkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@majst01 majst01 merged commit 3e1e012 into master Sep 14, 2022
@majst01 majst01 deleted the migrate-to-netip-netipx branch September 14, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants