Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usernames, Passwords and Database Names could in theory contain special characters - Secure passwords are highly likely to. With the current code, a password with special characters will result in the following error:
This is because the current connection string is in URI format - to make this work those fields should be URL escaped.
A more compact approach is to use the connection string format shown in the sqlx example
With this patch applied the connection will proceed successfully.
Signed-off-by: Dave Tucker dave@dtucker.co.uk