Fix postgres connection string #102
Conversation
This reverts commit c865256.
| want string | ||
| wantErr bool | ||
| }{ | ||
| { |
There was a problem hiding this comment.
you missed your special use case with an empty password in the tests here
There was a problem hiding this comment.
Thanks. I've amended the second commit and also used subtests to consume the name field from the test cases.
There was a problem hiding this comment.
I cannot reproduce the same test failure (tcp read).
On my Thinkpad, the tests pass via make test.
On my desktop, the tests time out, even on the master branch, even after extending the timeout to 20m.
Do you have any tips for reproducing this test environment or providing a way for me to re-run the Docker Build Action here on Github?
https://gist.github.com/ralfonso/d00c6a32feaae3dae83ca36f85152a53
There was a problem hiding this comment.
Running docker system prune seems to have resolved the timeouts on my desktop. The only place this is failing is in GH Actions.
This allows us to take advantage of net/url's ability to escape characters in username/password. It does not expose this feature via exported functions in the vein of EscapePath and EscapeQuery. The rules for escaping userinfo is slightly different.
ralfonso
force-pushed
the
fix-postgres-connection-string
branch
from
9ce0f0b
to
3618201
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #102 +/- ##
==========================================
- Coverage 70.69% 70.49% -0.20%
==========================================
Files 10 10
Lines 1126 1132 +6
==========================================
+ Hits 796 798 +2
- Misses 210 212 +2
- Partials 120 122 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This addresses the bug reported on the previous changeset that moved from a URI to a PostgreSQL specific space-delimited connection string.
Since this
postgresstorage type is perfectly fine for usage with CockroachDB, I've opted to revert back to the URI format since CockroachDB does not support to support the single quote form described in the libpq docs.This change takes advantage of
net/url's ability to escape characters in a URL's userinfo.