Spring cleaning and update rivets to latest release #205
Conversation
|
This came up when I tried using alloy in a go workspace. I thought workspaces were only for working on shared code bases without having to change deps in go.mod for dependencies specified in go.work but that doesn't seem to be right. It looks all the projects share a workspace (not unlike the old GOPATH days?) because alloy was failing to build when I added it to the go.work file, first because it referred to serverservice not fleetdb and then later the missing const. |
mmlb
force-pushed
the
update-rivets
branch
2 times, most recently
from
3a06963
to
e986d2b
Compare
mmlb
changed the title
Welp, I thought that maybe updating go and other stuff would fix this but nope... I'm also unsure whats going on since it works locally for me 😢 --- edit --- Internets thinks we need |
|
.github/workflows/release.yml
Outdated
| uses: actions/setup-go@v4 | ||
|
|
||
| - name: Set up Go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: "1.20" |
There was a problem hiding this comment.
shouldn't we rely on go.mod here?
There was a problem hiding this comment.
oops, yes we should. 1 moment.
The previous setup was inaccurate, only @joelrebel was actually setup as the CODEOWNER according to docs[1]. This commit also moves the GitHub centric file to the .github dir where other similar files already exist. 1: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
Files had mixed spacing for list and maps so I just threw prettier at it.
We can even specify the version so that we avoid different versions between ci and local dev machine. I'm using the same version and args as found in CI.
This way we have one and only-one way of doing things.
The action is able to read the go.mod version to discover what go version to install. So lets use that just like in ironlib to avoid needing to keep multiple files in sync. I got rid of GOVERSION used by goreleaser since its unnecessary, go embeds this info automatically. This is already being used, goreleaser was just overriding it. I also switched codeql-analysis to avoid autobuild because it failed trying to install go1.22 and we already have a way to build the binary, so lets re use it.
We've been pinned to an *unreleased* commit of rivets for a long time now. I blame go for not making this obvious. I decided to fix this now so that we can back on track and only use merged code paths. Getting the rivets PR merged and then updating this line comes next.
Do some spring cleaning like I've been doing to other repos here.
Also needed to update rivets because we've been pinned to an unreleased commit for a long time now. I blame go for not making this obvious. I decided to fix this now so that we can back on track and only use merged code paths. Getting the rivets PR merged and then updating this line comes next.