Add validations for Image.DiskFormat

Signed-off-by: Zhou Hao <zhouhao@fujitsu.com>
metal3-io · Aug 15, 2022 · 71ba67d · 71ba67d
1 parent fb29032
commit 71ba67d
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/apis/metal3.io/v1alpha1/baremetalhost_validation.go b/apis/metal3.io/v1alpha1/baremetalhost_validation.go
@@ -76,6 +76,7 @@ func (host *BareMetalHost) validateChanges(old *BareMetalHost) []error {
 
 func validateBMCAccess(s BareMetalHostSpec, bmcAccess bmc.AccessDetails) []error {
 	var errs []error
+	diskFormat := "live-iso"
 
 	if bmcAccess == nil {
 		return errs
@@ -108,6 +109,10 @@ func validateBMCAccess(s BareMetalHostSpec, bmcAccess bmc.AccessDetails) []error
 		errs = append(errs, fmt.Errorf("BMC driver %s does not support secure boot", bmcAccess.Type()))
 	}
 
+	if s.Image != nil && s.Image.DiskFormat != nil && *s.Image.DiskFormat == diskFormat && !bmcAccess.SupportsISOPreprovisioningImage() {
+		errs = append(errs, fmt.Errorf("BMC driver %s does not support live-iso image", bmcAccess.Type()))
+	}
+
 	return errs
 }
 

diff --git a/apis/metal3.io/v1alpha1/baremetalhost_validation_test.go b/apis/metal3.io/v1alpha1/baremetalhost_validation_test.go
@@ -46,6 +46,7 @@ func TestValidateCreate(t *testing.T) {
 
 	// for RAID validation test cases
 	numberOfPhysicalDisks := 3
+	diskFormat := "live-iso"
 
 	tests := []struct {
 		name      string
@@ -455,6 +456,25 @@ func TestValidateCreate(t *testing.T) {
 			oldBMH:    nil,
 			wantedErr: "Image URL test1 is an invalid URL",
 		},
+		{
+			name: "liveISOImageWithUnsupportBMC",
+			newBMH: &BareMetalHost{
+				TypeMeta:   tm,
+				ObjectMeta: om,
+				Spec: BareMetalHostSpec{
+					BMC: BMCDetails{
+						Address:         "idrac://127.0.0.1",
+						CredentialsName: "test1",
+					},
+					Image: &Image{
+						URL:        "http://127.0.0.1",
+						DiskFormat: &diskFormat,
+					},
+				}, // end of BMH spec
+			},
+			oldBMH:    nil,
+			wantedErr: "BMC driver idrac does not support live-iso image",
+		},
 	}
 
 	for _, tt := range tests {