make lint only checks root and test folders

[lentzi90]

What steps did you take and what happened:

make lint is only checking the repo root and test, as can be seen here:

baremetal-operator/Makefile

Lines 127 to 130 in c493623

	.PHONY: lint
	lint: tools/bin/golangci-lint
	$< run
	cd test; ../$< run

What did you expect to happen:

I think we should at least check apis and possibly also pkg/hardwareutils, similar to what we do for make mod

baremetal-operator/Makefile

Lines 300 to 311 in c493623

	.PHONY:
	mod: ## Clean up go module settings
	go mod tidy
	go mod verify
	cd apis; go mod tidy
	cd apis; go mod verify
	cd pkg/hardwareutils; go mod tidy
	cd pkg/hardwareutils; go mod verify
	cd hack/tools; go mod tidy
	cd hack/tools; go mod verify
	cd test; go mod tidy
	cd test; go mod verify

Anything else you would like to add:

We seem to have a few linting errors in apis already from a quick test. Nothing too serious but it would be good to make sure we do not introduce more issues.

Environment:

• Baremetal Operator version: main
• Environment (metal3-dev-env or other): irrelevant

/kind bug

[kashifest]

I propose to fix it as we do in CAPM3. We run golangci as a github workflow here. Advantage is one less prow job. For local dev and test, we can do something similar to https://github.com/metal3-io/cluster-api-provider-metal3/blob/main/Makefile#L279-L282. If this is ok, I can push a PR.
cc @lentzi90 @dtantsur @honza @zaneb

[dtantsur]

Works for me.

/triage accepted

[metal3-io-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[lentzi90]

/remove-lifecycle stale

[lentzi90]

@kashifest was this fixed in #1536?

[kashifest]

#1536

@kashifest was this fixed in #1536?

Yes. This is now fixed. I am planning to perhaps retire the prow job but the phony is fixed to test locally.

/close

[metal3-io-bot]

@kashifest: Closing this issue.

In response to this:

#1536

@kashifest was this fixed in #1536?
Yes. This is now fixed. I am planning to perhaps retire the prow job but the phony is fixed to test locally.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.