Get rid of envsubst for nameprefix #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
metal3-io-bot
added
do-not-merge/work-in-progress
|
/test-v1b1-ubuntu-integration |
lentzi90
force-pushed
the
lentzi90/no-envsubst-prefix
branch
from
556ec71
to
5a874b8
Compare
|
/test-v1b1-ubuntu-integration |
lentzi90
force-pushed
the
lentzi90/no-envsubst-prefix
branch
from
5a874b8
to
0e2c464
Compare
The Ironic kustomizations used envsubst to set the nameprefix, while BMO was using the built in feature in kustomize. To unify them and simplify the deploy script a bit, the Ironix kustomizations were changed to also use the kustomize feature. There is a slight change in the manifests since the namePrefix is applied also to secrets, configmaps and label selectors that didn't have the prefix set before. The namespace is now also created as part of the kustomizations for Ironic (same as for BMO).
lentzi90
force-pushed
the
lentzi90/no-envsubst-prefix
branch
from
0e2c464
to
c96d939
Compare
metal3-io-bot
removed
the
do-not-merge/work-in-progress
|
/test-v1b1-ubuntu-integration |
1 similar comment
|
/test-v1b1-ubuntu-integration |
|
/test-v1b1-centos-integration |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ironic kustomizations used envsubst to set the nameprefix, while BMO
was using the built in feature in kustomize. To unify them and simplify
the deploy script a bit, the Ironix kustomizations were changed to also
use the kustomize feature.
There is a slight change in the manifests since the namePrefix is
applied also to secrets, configmaps and label selectors that didn't have
the prefix set before.
The namespace is now also created as part of the kustomizations for
Ironic (same as for BMO).
Fixes #1072
Edit:
This breaks CAPM3 v1alpha4 (which is deprecated). The issue is that Ironic ends up in the wrong namespace. It is easily solve by copying the
ironic-cacertsecret to the namespace where BMO is running (capm3-system) or making changes to the Ironic manifests. However, v1alpha4 is no longer supported so I'm a bit hesitant to add something specific to that version.In addition to this, v1alpha4 uses Kubernetes v1.21, which is EOL in just a few weeks. So it makes sense to not focus on this old version in my opinion. But of course, let me know if there are objections!