Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not consider empty RAID and root device hints updated #1134

Merged
merged 1 commit into from Feb 1, 2023

Conversation

dtantsur
Copy link
Member

Currently, due to the way we compare these fields in Spec and Status,
we always trigger an update at least once. Avoid it if the fields are
completely empty.

Extract the root device hints function and call it when matching the
profile to avoid a new update later on.

Improve logging around the diff handling.

Currently, due to the way we compare these fields in Spec and Status,
we always trigger an update at least once. Avoid it if the fields are
completely empty.

Extract the root device hints function and call it when matching the
profile to avoid a new update later on.

Improve logging around the diff handling.
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 14, 2022
@dtantsur
Copy link
Member Author

/test-v1b1-centos-integration
/test-v1b1-ubuntu-integration

@elfosardo
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2022
@elfosardo
Copy link
Member

/test-v1b1-centos-integration
/test-v1b1-ubuntu-integration

@elfosardo
Copy link
Member

/test-ubuntu-integration-main
/test-centos-integration-main

@zaneb
Copy link
Member

zaneb commented Sep 14, 2022

/cc @Hellcatlk

@Hellcatlk
Copy link
Member

Thanks, lgtm.

@metal3-io-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 15, 2022
@dtantsur
Copy link
Member Author

dtantsur commented Dec 15, 2022

/remove-lifecycle stale

@dtantsur dtantsur removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 15, 2022
@furkatgofurov7
Copy link
Member

Please label the PR appropriately based on https://github.com/metal3-io/baremetal-operator/blob/main/CONTRIBUTING.md#contributing-a-patch to make it easier to sort it out while releasing in the changelog, thanks!

@honza
Copy link
Member

honza commented Feb 1, 2023

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: honza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2023
@metal3-io-bot metal3-io-bot merged commit 4d917f6 into metal3-io:main Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants