New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not consider empty RAID and root device hints updated #1134
Conversation
Currently, due to the way we compare these fields in Spec and Status, we always trigger an update at least once. Avoid it if the fields are completely empty. Extract the root device hints function and call it when matching the profile to avoid a new update later on. Improve logging around the diff handling.
/test-v1b1-centos-integration |
/lgtm |
/test-v1b1-centos-integration |
/test-ubuntu-integration-main |
/cc @Hellcatlk |
Thanks, lgtm. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
/remove-lifecycle stale |
Please label the PR appropriately based on https://github.com/metal3-io/baremetal-operator/blob/main/CONTRIBUTING.md#contributing-a-patch to make it easier to sort it out while releasing in the changelog, thanks! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: honza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Currently, due to the way we compare these fields in Spec and Status,
we always trigger an update at least once. Avoid it if the fields are
completely empty.
Extract the root device hints function and call it when matching the
profile to avoid a new update later on.
Improve logging around the diff handling.