Don't register in Inspecting if inspection disabled #1137
Conversation
When inspection is disabled, the host still passes through the inspecting state. Previously, we would still try to register the host in this state, which would mean that it would require a valid PreprovisioningImage to continue. Since no image is needed if we are not actually going to inspect, skip registration in this case.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cc @dtantsur |
metal3-io-bot
added
the
size/XS
|
I think #1128 is actually the right thing to do and has less potential side effects. |
|
/close |
|
@zaneb: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When inspection is disabled, the host still passes through the
inspecting state. Previously, we would still try to register the host in
this state, which would mean that it would require a valid
PreprovisioningImage to continue. Since no image is needed if we are not
actually going to inspect, skip registration in this case.