Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃尡 Add Lennart Jern as a reviewer #1194

Merged
merged 1 commit into from Dec 13, 2022
Merged

馃尡 Add Lennart Jern as a reviewer #1194

merged 1 commit into from Dec 13, 2022

Conversation

kashifest
Copy link
Member

Following community standard, since Lennart has more than 10 commits, adding him as a reviewer here.

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 9, 2022
@kashifest
Copy link
Member Author

/test-ubuntu-integration-main
/test-centos-integration-main

furkatgofurov7
furkatgofurov7 reviewed Dec 9, 2022
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all contributions @lentzi90 and welcome!
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2022
@furkatgofurov7
Copy link
Member

/test-centos-integration-main

@kashifest
Copy link
Member Author

/cc @dtantsur @honza @zaneb

@dtantsur
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2022
@kashifest
Copy link
Member Author

/retest

@kashifest
Copy link
Member Author

/test all

@metal3-io-bot
Copy link
Contributor

@kashifest: No jobs can be run with /test all.
The following commands are available to trigger required jobs:

  • /test generate
  • /test gofmt
  • /test golint
  • /test gomod
  • /test gosec
  • /test manifestlint
  • /test markdownlint
  • /test shellcheck
  • /test unit

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kashifest
Copy link
Member Author

/test generate
/test gofmt
/test golint
/test gomod
/test gosec
/test manifestlint
/test markdownlint
/test shellcheck
/test unit

@kashifest kashifest closed this Dec 13, 2022
@kashifest kashifest reopened this Dec 13, 2022
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2022
@kashifest
Copy link
Member Author

/test-ubuntu-integration-main
/test-centos-integration-main

furkatgofurov7
furkatgofurov7 reviewed Dec 13, 2022
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2022
@kashifest
Copy link
Member Author

/test-ubuntu-integration-main
/test-centos-integration-main

@metal3-io-bot metal3-io-bot merged commit 4ce3a6b into metal3-io:main Dec 13, 2022
@kashifest kashifest deleted the add/Lennart branch October 5, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@dtantsur dtantsur Awaiting requested review from dtantsur

@honza honza Awaiting requested review from honza

@zaneb zaneb Awaiting requested review from zaneb

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kashifest @furkatgofurov7 @dtantsur @metal3-io-bot