馃尡 Separate updating images from ValidateManagementAccess #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contrary to its name, ValidateManagementAccess also enrolls the node and configures various deploy-related parameters. This change splits cleaning, image, custom deploy and ramdisk settings to a new function with a goal to eventually delineate them. Fix tryUpdateNode to return the updated node.
metal3-io-bot
added
the
size/L
|
/test-centos-integration-main |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: honza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
/lgtm |
|
/retest |
|
/test all |
|
/lgtm |
|
/test all |
|
@dtantsur can you please repush the branch (rebased on top of main)? I can lgtm it after, since it will be gone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contrary to its name, ValidateManagementAccess also enrolls the node and
configures various deploy-related parameters. This change splits
cleaning, image, custom deploy and ramdisk settings to a new function
with a goal to eventually delineate them.
Fix tryUpdateNode to return the updated node.