Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 bump kustomize to v4.5.7 #1214

Merged
merged 1 commit into from Feb 14, 2023
Merged

馃悰 bump kustomize to v4.5.7 #1214

merged 1 commit into from Feb 14, 2023

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Feb 13, 2023 •
edited

This gets rid of vulnerable emicklei/go-restful/v1 dependency. v3 at 3.8.0 is OK.

GHSA-r48q-9g5r-8q2h

@metal3-io-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@metal3-io-bot metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 13, 2023
@tuminoid
Copy link
Member Author

/test all

@tuminoid
Copy link
Member Author

/test-centos-integration-main
/test-ubuntu-integration-main

@tuminoid
bump kustomize to v4.5.7
64574f9 
This gets rid of vulnerable go-restful dependency.
@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 14, 2023
@tuminoid tuminoid changed the title 馃悰 bump go-restful to 2.16.0 馃悰 bump kustomize to v4.5.7 Feb 14, 2023
@tuminoid tuminoid marked this pull request as ready for review February 14, 2023 08:19
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 14, 2023
@tuminoid
Copy link
Member Author

/test-centos-integration-main
/test-ubuntu-integration-main

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2023
@Rozzii
Copy link
Member

Rozzii commented Feb 14, 2023

/lgtm

@metal3-io-bot
Copy link
Contributor

@Rozzii: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid
Copy link
Member Author

/cc @lentzi90

furkatgofurov7
furkatgofurov7 reviewed Feb 14, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2023
@metal3-io-bot metal3-io-bot merged commit fb26394 into metal3-io:main Feb 14, 2023
@tuminoid tuminoid deleted the tuomo/bump-go-restful branch February 15, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@kashifest kashifest kashifest approved these changes

@lentzi90 lentzi90 Awaiting requested review from lentzi90

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tuminoid @metal3-io-bot @Rozzii @furkatgofurov7 @kashifest