Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace package "text" with "google/safetext" #1215

Merged
merged 1 commit into from Apr 4, 2023
Merged

Replace package "text" with "google/safetext" #1215

merged 1 commit into from Apr 4, 2023

Conversation

PlotCondor
Copy link
Contributor

The library "text/template" is syntax-unaware and at risk of injection vulnerabilities. More context.

Signed-off-by: Jie Yang jieyangnku@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@metal3-io-bot metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 13, 2023
@metal3-io-bot
Copy link
Contributor

Hi @PlotCondor. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 13, 2023
@PlotCondor
Copy link
Contributor Author

/test all
/test-centos-integration-main
/test-ubuntu-integration-main

@metal3-io-bot
Copy link
Contributor

@PlotCondor: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all
/test-centos-integration-main
/test-ubuntu-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@PlotCondor
Copy link
Contributor Author

/assign @honz

@metal3-io-bot
Copy link
Contributor

@PlotCondor: GitHub didn't allow me to assign the following users: honz.

Note that only metal3-io members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @honz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid
Copy link
Member

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 14, 2023
@PlotCondor
Copy link
Contributor Author

/retest

@PlotCondor PlotCondor closed this Feb 14, 2023
@metal3-io-bot metal3-io-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 14, 2023
@PlotCondor PlotCondor reopened this Feb 14, 2023
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 14, 2023
@PlotCondor PlotCondor closed this Feb 16, 2023
@metal3-io-bot metal3-io-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 16, 2023
@PlotCondor PlotCondor reopened this Feb 16, 2023
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 16, 2023
@PlotCondor PlotCondor closed this Feb 16, 2023
@metal3-io-bot metal3-io-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 16, 2023
Replace package "text" with "google/safetext"
bb0d050 
The library "text/template" is syntax-unaware and at risk of injection
vulnerabilities. [More context](https://github.com/google/safetext).

Signed-off-by: Jie Yang <jieyangnku@gmail.com>
@PlotCondor PlotCondor reopened this Feb 16, 2023
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 16, 2023
@tuminoid
Copy link
Member

/retest

@tuminoid
Copy link
Member

/test-centos-integration-main
/test-ubuntu-integration-main

@tuminoid
Copy link
Member

Was there an issue with the checks @PlotCondor? I'm trying to understand the need to close/reopen?

@PlotCondor
Copy link
Contributor Author

Was there an issue with the checks @PlotCondor? I'm trying to understand the need to close/reopen?

I was rebasing on my fork. This change should be ready to review.

@PlotCondor
Copy link
Contributor Author

Any comments on this patch?

@tuminoid
Copy link
Member

tuminoid commented Mar 2, 2023

/test-centos-integration-e2e-main

tuminoid
tuminoid approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit to me.

/cc @kashifest

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2023
@kashifest
Copy link
Member

@honza @zaneb PTAL

@PlotCondor
Copy link
Contributor Author

@kashifest Can we merge this PR?

@zaneb
Copy link
Member

zaneb commented Apr 3, 2023

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2023
@kashifest
Copy link
Member

/test-centos-e2e-integration-main

@tuminoid
Copy link
Member

tuminoid commented Apr 4, 2023

@PlotCondor Can you rebase on top of main? I'm fairly sure tide cannot merge this anymore, it has been having issues lately with older (and newer) PRs.

@metal3-io-bot metal3-io-bot merged commit e2d11fe into metal3-io:main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid approved these changes

@kashifest kashifest kashifest approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PlotCondor @metal3-io-bot @tuminoid @kashifest @zaneb