Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Revert "run BMO deployment as non-root" #1239

Merged
merged 1 commit into from Mar 24, 2023

Conversation

tuminoid
Copy link
Member

This reverts commit 4908f57, PR #1231

We missed mariadb's securityContext (there is no CI tests for such combination) and we also have release branch failures related to unversioned keepalived image, and 1.1 and 1.2 branches fail to run with latest keepalived image.

I will reintroduce this PR when those issues are addressed, before 1.4 release cycle.

This reverts commit 4908f57.

We missed mariadb securityContext and we also have conflict in
release branches related to unversioned keepalived image, which breaks
the branches.
@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 24, 2023
@tuminoid
Copy link
Member Author

/test-ubuntu-integration-main
/test-centos-e2e-integration-main

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2023
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2023
@metal3-io-bot metal3-io-bot merged commit 6a798be into metal3-io:main Mar 24, 2023
@tuminoid tuminoid deleted the tuomo/revert-nonroot-bmo-pr branch March 24, 2023 09:34
@tuminoid
Copy link
Member Author

FYI @dtantsur @elfosardo we rolled this back. See description for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants