Use same settings for provisioner and controller logs #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Structured logging tools expect a POSIX timestamp. Only change the timestamp formatting in development log mode.
Previously the ironic provisioner log was created in a separate module, and didn't have access to the CLI arguments. Originally the provisioner was always in structured mode even when the -dev flag was passed to put it into development mode, and then after metal3-io#1175 vice-versa. Create the provisioning logger in main.go using the same settings as the controller logger, and pass it in to the provisioner factory. Fixes metal3-io#1248
metal3-io-bot
added
the
size/S
|
/test-centos-e2e-integration-main |
|
Looks like cert-manager failed to deploy for some reason. Let's rerun. The logs on the ubuntu test looks good btw! |
|
/test-centos-e2e-integration-main |
|
/cc @honza |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: honza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the ironic provisioner log was created in a separate module,
and didn't have access to the CLI arguments. Originally the provisioner
was always in structured mode even when the -dev flag was passed to put
it into development mode, and then after #1175 vice-versa.
Create the provisioning logger in main.go using the same settings as the
controller logger, and pass it in to the provisioner factory. Only change the
timestamp formatting in development log mode.