🐛 Don't check for ironic capacity in 'deleting' state #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ironic doesn't do any work to speak of in the host's 'deleting' state. It appears this was added (in c3c2c88) due to confusion between ironic's 'deleting' (i.e. the 'deprovisioning' state in Metal³) and Metal³'s 'deleting' state. A result of this was that hosts in the 'unmanaged' state could not be deleted, because by definition they do not have BMC credentials, but the check for Ironic capacity required them. Since unmanaged hosts do not go through 'deprovisioning', removing this unnecessary check from the 'deleting' state should be enough to allow them to be deleted again.
|
/cc @dtantsur |
metal3-io-bot
added
the
size/XS
|
/test-centos-e2e-integration-main |
|
/lgtm |
|
/test-centos-e2e-integration-main |
Merged
20 tasks
|
/assign @andfasano |
andfasano
reviewed
May 8, 2023
This is no longer needed now that we don't wait for provisioner capacity when going from deprovisioning->deleting.
metal3-io-bot
added
size/S
|
/test-centos-e2e-integration-main |
1 similar comment
|
/test-centos-e2e-integration-main |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
rhjanders
pushed a commit
to rhjanders/baremetal-operator
that referenced
this pull request
May 23, 2023
🐛 Don't check for ironic capacity in 'deleting' state (cherry picked from commit e59dd39)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ironic doesn't do any work to speak of in the host's 'deleting' state. It appears this was added (in c3c2c88) due to confusion between ironic's 'deleting' (i.e. the 'deprovisioning' state in Metal³) and Metal³'s 'deleting' state.
A result of this was that hosts in the 'unmanaged' state could not be deleted, because by definition they do not have BMC credentials, but the check for Ironic capacity required them. Since unmanaged hosts do not go through 'deprovisioning', removing this unnecessary check from the 'deleting' state should be enough to allow them to be deleted again.