Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃摉 update releasing.md with links to main process #1266

Merged
merged 1 commit into from May 8, 2023
Merged

馃摉 update releasing.md with links to main process #1266

merged 1 commit into from May 8, 2023

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented May 2, 2023 •
edited

Update releasing.md to refer to main process documentation for post-release steps.

  1. Link to the metal3-docs releasing.md
  2. Fix the go module tagging not to be annotated (release workflow might get messed up, only primary tag to be annotated)

@metal3-io-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 2, 2023
@tuminoid
Copy link
Member Author

tuminoid commented May 2, 2023

Link check will fail until metal3-io/metal3-docs#321 is merged.

/hold

@metal3-io-bot metal3-io-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 2, 2023
@tuminoid tuminoid force-pushed the tuomo/update-releasing-docs branch from 9a7525a to e0215a1 Compare May 8, 2023 06:57
@tuminoid tuminoid marked this pull request as ready for review May 8, 2023 07:05
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2023
@tuminoid
Copy link
Member Author

tuminoid commented May 8, 2023

/unhold
/test-ubuntu-integration-main
/test-centos-e2e-integration-main

Main doc has been merged, URL checks are passing

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 8, 2023
@tuminoid tuminoid force-pushed the tuomo/update-releasing-docs branch from e0215a1 to ab47710 Compare May 8, 2023 08:17
@tuminoid
Copy link
Member Author

tuminoid commented May 8, 2023

/test-ubuntu-integration-main
/test-centos-e2e-integration-main

@tuminoid
Copy link
Member Author

tuminoid commented May 8, 2023

/cc @furkatgofurov7 @kashifest @lentzi90

lentzi90
lentzi90 reviewed May 8, 2023
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2023
@tuminoid
update releasing.md with links to main process
45c5b8a 
Update releasing.md to refer to main process documentation for
post-release steps.
@tuminoid tuminoid force-pushed the tuomo/update-releasing-docs branch from ab47710 to 45c5b8a Compare May 8, 2023 10:03
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label May 8, 2023
@tuminoid
Copy link
Member Author

tuminoid commented May 8, 2023

/test-ubuntu-integration-main
/test-centos-e2e-integration-main

@tuminoid
Copy link
Member Author

tuminoid commented May 8, 2023

/test-centos-e2e-integration-main

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2023
furkatgofurov7
furkatgofurov7 reviewed May 8, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2023
@metal3-io-bot metal3-io-bot merged commit 6f48445 into metal3-io:main May 8, 2023
5 checks passed
@tuminoid tuminoid deleted the tuomo/update-releasing-docs branch May 8, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@kashifest kashifest kashifest approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tuminoid @metal3-io-bot @lentzi90 @furkatgofurov7 @kashifest