Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 pin distroless to static:nonroot with sha digest #1267

Merged
merged 1 commit into from May 3, 2023

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented May 3, 2023

Change distroless from base:latest to static:nonroot like other controller images, and pin it with sha digest.

Change distroless from base:latest to static:nonroot like other
controller images, and pin it with sha digest.
@metal3-io-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@metal3-io-bot metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 3, 2023
@tuminoid
Copy link
Member Author

tuminoid commented May 3, 2023

/test all
/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@tuminoid tuminoid marked this pull request as ready for review May 3, 2023 06:28
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 3, 2023
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2023
@dtantsur
Copy link
Member

dtantsur commented May 3, 2023

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2023
@metal3-io-bot metal3-io-bot merged commit b76dde2 into metal3-io:main May 3, 2023
8 checks passed
@tuminoid tuminoid deleted the tuomo/pin-distroless branch May 3, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants