⚠️Move hardware profile code to the api module #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this code now defines how we map one API concept (the hardware profile string) to default values for other API concepts (root device hints), it is effectively part of the API definition. It is also not expected to exist in future API versions. The webhook for translating hosts between versions will need to access this code, so it will need to be inside the API module. Finally, similar to the hardwareutils module, this is useful in other contexts and moving it out of the main module eliminates extraneous external dependencies being dragged with it.
metal3-io-bot
added
the
size/M
|
/cc @dtantsur |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
/lgtm |
smoshiur1237
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this code now defines how we map one API concept (the hardware profile string) to default values for other API concepts (root device hints), it is effectively part of the API definition. It is also not expected to exist in future API versions. The webhook for translating hosts between versions will need to access this code, so it will need to be inside the API module. Finally, similar to the hardwareutils module, this is useful in other contexts and moving it out of the main module eliminates extraneous external dependencies being dragged with it.