馃尡 Stop using Extra when building hardware inventory #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The core inventory has all we need. Extra comes from a plug-in that may not be present (e.g. in upstream IPA images).
metal3-io-bot
added
the
size/L
|
/test-centos-e2e-integration-main |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: honza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
dtantsur
added a commit
to dtantsur/ironic-image
that referenced
this pull request
Jun 22, 2023
After metal3-io/baremetal-operator#1297, it is no longer needed. Upstream ramdisks do not support it.
|
/lgtm |
|
@derekhiggins: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
dtantsur
added a commit
to dtantsur/ironic-image
that referenced
this pull request
Feb 26, 2024
After metal3-io/baremetal-operator#1297, it is no longer needed. Upstream ramdisks do not support it.
dtantsur
added a commit
to dtantsur/ironic-agent-image
that referenced
this pull request
Feb 28, 2024
Not used in BMO since metal3-io/baremetal-operator#1297.
dtantsur
added a commit
to dtantsur/ironic-agent-image
that referenced
this pull request
Feb 29, 2024
Not used in BMO since metal3-io/baremetal-operator#1297.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core inventory has all we need. Extra comes from a plug-in that
may not be present (e.g. in upstream IPA images).