Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix code quality issues in BMO TLS configuration code #1327

Merged
merged 1 commit into from Aug 14, 2023
Merged

🐛 Fix code quality issues in BMO TLS configuration code #1327

merged 1 commit into from Aug 14, 2023

Conversation

as20203
Copy link
Member

@as20203 as20203 commented Aug 9, 2023

Fixed the code quality issues mentioned in 1320

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 9, 2023
@as20203 as20203 mentioned this pull request Aug 9, 2023
Closed
3 tasks
@as20203 as20203 force-pushed the jawad/bmo-tls-configuration branch from c9a443b to 67e494a Compare August 9, 2023 09:33
@as20203
Copy link
Member Author

as20203 commented Aug 9, 2023

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@as20203
Copy link
Member Author

as20203 commented Aug 9, 2023

@tuminoid please review

@tuminoid
Copy link
Member

tuminoid commented Aug 9, 2023

/retitle 🌱 Fix code quality issues in BMO TLS configuration code

@metal3-io-bot metal3-io-bot changed the title ✨ Fixed code quality issues in bmo tls configuration 🌱 Fix code quality issues in BMO TLS configuration code Aug 9, 2023
@tuminoid
Copy link
Member

tuminoid commented Aug 9, 2023

/cc @zaneb
You raised these issues in code review of #1282, please review the fixes.

@tuminoid tuminoid self-requested a review August 9, 2023 10:39
@zaneb
Copy link
Member

zaneb commented Aug 11, 2023

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2023
tuminoid
tuminoid approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @kashifest

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2023
@metal3-io-bot metal3-io-bot merged commit ba4cc53 into metal3-io:main Aug 14, 2023
10 checks passed
@smoshiur1237 smoshiur1237 changed the title 🌱 Fix code quality issues in BMO TLS configuration code 🐛 Fix code quality issues in BMO TLS configuration code Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid approved these changes

@kashifest kashifest kashifest approved these changes

@zaneb zaneb Awaiting requested review from zaneb

Assignees

@kashifest kashifest

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@as20203 @tuminoid @zaneb @metal3-io-bot @kashifest