Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃尡 Bump golangci-lint to v1.54.2 #1337

Merged
merged 1 commit into from Aug 24, 2023
Merged

馃尡 Bump golangci-lint to v1.54.2 #1337

merged 1 commit into from Aug 24, 2023

Conversation

kashifest
Copy link
Member

v1.54.2 golangci-lint patch has introduced some new rules for gosec. This PR bump the golangci-lint and fixes the code since dependabot PR couldn't fix it automatically.

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 22, 2023
@kashifest
Copy link
Member Author

/test-ubuntu-integration-main
/test-centos-e2e-integration-main

@kashifest kashifest mentioned this pull request Aug 22, 2023
Closed
@honza
Copy link
Member

honza commented Aug 22, 2023

We just merged an upgrade of golangci-lint yesterday, let's keep an eye on the frequency, it's starting to get tedious.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: honza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2023
@kashifest
Copy link
Member Author

We just merged an upgrade of golangci-lint yesterday, let's keep an eye on the frequency, it's starting to get tedious.

Yes, unfortunately the patch version came out after that and dependabot was trying to bump it but with issues.

@kashifest
Copy link
Member Author

/test-ubuntu-integration-main

@zhouhao3
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2023
@metal3-io-bot metal3-io-bot merged commit 10d5e43 into metal3-io:main Aug 24, 2023
10 checks passed
@kashifest kashifest deleted the bump/golangci-lint-v1.54.2 branch October 5, 2023 06:36
@kashifest kashifest restored the bump/golangci-lint-v1.54.2 branch October 5, 2023 06:36
@kashifest kashifest deleted the bump/golangci-lint-v1.54.2 branch October 5, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kashifest @honza @metal3-io-bot @zhouhao3