📖 improve release notes tool #1348
Conversation
tuminoid
commented
Sep 1, 2023
tuminoid
commented
- Add missing empty link after release image before thanking contributors
- Add superseded or reverted category, which is filled manually but present 99% every time, so it is consistent
metal3-io-bot
added
the
size/S
|
/test-centos-e2e-integration-main |
|
/lgtm |
|
@Rozzii: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
hack/tools/release_notes.go
Outdated
| @@ -42,6 +42,7 @@ const ( | |||
| warning = ":warning: Breaking Changes" | |||
| other = ":seedling: Others" | |||
| unknown = ":question: Sort these by hand" | |||
| superseded = ":arrow_up: Superseded or Reverted" | |||
There was a problem hiding this comment.
nit/question: Why ⬆️? It seems more like "upgrade" to me. Maybe ⏪ would fit better?
There was a problem hiding this comment.
Most of them are superseded bumps, bumps go up in my mind. 😄
I'm open to other icons, but prefer not defaulting to << which is revert focused (again, to my context).
There was a problem hiding this comment.
We could go for 👻 or 💀 (dead PRs), 🔙 (back'd away),
There was a problem hiding this comment.
Hehe I like 👻 ! 💨 (gone already) could maybe work? No strong opinions from me though, I was just curious about the ⬆️
There was a problem hiding this comment.
I agree that there are better options than ⬆️, it just felt relevant at the time.
@elfosardo @zaneb @dtantsur @honza feel free to throw in your 2 cents as well.
There was a problem hiding this comment.
Changed to ♻️ after discussion.
- Add missing empty link after release image. - Add superseded or reverted category, which is filled manually but present everytime
tuminoid
force-pushed
the
tuomo/improve-release-notes-tool
branch
from
e3c4c2f
to
2d332c1
Compare
|
/test-centos-e2e-integration-main |
|
/unhold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
