Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃尡 Implement Detached/Status Annotation E2E Test #1434

Merged
merged 1 commit into from Nov 13, 2023
Merged

馃尡 Implement Detached/Status Annotation E2E Test #1434

merged 1 commit into from Nov 13, 2023

Conversation

maxrantil
Copy link
Member

What this PR does / why we need it:
Validate BMH status retention across delete & recreate with annotations.

Fixes #1368

@metal3-io-bot metal3-io-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 7, 2023
@lentzi90
Copy link
Member

lentzi90 commented Nov 7, 2023

/metal3-bmo-e2e-test

@maxrantil maxrantil force-pushed the add-detached-and-status-annotation-e2e-test/max branch from 726800e to 1cf455c Compare November 8, 2023 05:52
@maxrantil
Copy link
Member Author

/metal3-bmo-e2e-test

@maxrantil maxrantil force-pushed the add-detached-and-status-annotation-e2e-test/max branch 2 times, most recently from f6de6dd to 24269c8 Compare November 8, 2023 06:20
@lentzi90
Copy link
Member

lentzi90 commented Nov 8, 2023

/metal3-bmo-e2e-test

lentzi90
lentzi90 reviewed Nov 8, 2023
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great job!
As discussed off-line, we could make turn some of this into generic functions, but I would say it is preferable to merge this first and then follow up with a refactor. Then we can also change other tests at the same time, e.g. to add a CreateSecret function used by all of them.

test/e2e/basic_provisioning_test.go Outdated Show resolved Hide resolved
test/e2e/basic_provisioning_test.go Outdated Show resolved Hide resolved
test/e2e/basic_provisioning_test.go Outdated Show resolved Hide resolved
test/e2e/basic_provisioning_test.go Outdated Show resolved Hide resolved
test/e2e/basic_provisioning_test.go Show resolved Hide resolved
test/e2e/basic_provisioning_test.go Show resolved Hide resolved
test/e2e/basic_provisioning_test.go Outdated Show resolved Hide resolved
test/e2e/basic_provisioning_test.go Outdated Show resolved Hide resolved
@maxrantil maxrantil force-pushed the add-detached-and-status-annotation-e2e-test/max branch from 24269c8 to bac84bd Compare November 8, 2023 11:00
@maxrantil
Copy link
Member Author

/metal3-bmo-e2e-test

@maxrantil
Copy link
Member Author

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

lentzi90
lentzi90 reviewed Nov 8, 2023
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2023
@maxrantil
Copy link
Member Author

/test-centos-e2e-integration-main

@maxrantil
Copy link
Member Author

maxrantil commented Nov 8, 2023 •
edited

/cc @kashifest @dtantsur

@maxrantil
Implement Detached/Status Annotation E2E Test
587056e 
Validate BMH status retention across delete & recreate with annotations.
@maxrantil maxrantil force-pushed the add-detached-and-status-annotation-e2e-test/max branch from bac84bd to 587056e Compare November 13, 2023 15:14
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2023
@maxrantil
Copy link
Member Author

/metal3-bmo-e2e-test
/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@kashifest
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2023
@kashifest
Copy link
Member

Re-adding the lgtm as well since that went away for the comment change.
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2023
@metal3-io-bot metal3-io-bot merged commit 4841baa into metal3-io:main Nov 13, 2023
14 checks passed
@metal3-io-bot metal3-io-bot deleted the add-detached-and-status-annotation-e2e-test/max branch November 13, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@kashifest kashifest kashifest left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add detached and status annotation e2e test
4 participants
@maxrantil @lentzi90 @kashifest @metal3-io-bot