Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃尡E2e live iso ssh implementation #1453

Merged
merged 1 commit into from Dec 1, 2023
Merged

馃尡E2e live iso ssh implementation #1453

merged 1 commit into from Dec 1, 2023

Conversation

maxrantil
Copy link
Member

Fixes #1429

@metal3-io-bot metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 20, 2023
@maxrantil
Copy link
Member Author

/metal3-bmo-e2e-test

@maxrantil maxrantil force-pushed the e2e-live-iso-ssh-implementation/max branch from 762c5e7 to afe00df Compare November 21, 2023 06:50
@metal3-io-bot metal3-io-bot added needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 21, 2023
@maxrantil
Copy link
Member Author

/metal3-bmo-e2e-test

@maxrantil
Copy link
Member Author

/test-ubuntu-integration-main

@maxrantil maxrantil force-pushed the e2e-live-iso-ssh-implementation/max branch from 94c79bd to 755098b Compare November 21, 2023 07:14
@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Nov 21, 2023
@maxrantil maxrantil force-pushed the e2e-live-iso-ssh-implementation/max branch from 755098b to 372588f Compare November 21, 2023 07:40
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Nov 21, 2023
@maxrantil maxrantil force-pushed the e2e-live-iso-ssh-implementation/max branch 3 times, most recently from 18d3738 to 1b1f9c4 Compare November 21, 2023 11:25
@maxrantil
Copy link
Member Author

/test gomod

@maxrantil maxrantil force-pushed the e2e-live-iso-ssh-implementation/max branch 2 times, most recently from 47765a8 to c312356 Compare November 21, 2023 13:05
@maxrantil maxrantil changed the title WIP: 馃尡E2e live iso ssh implementation/max 馃尡E2e live iso ssh implementation/max Nov 21, 2023
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2023
@maxrantil maxrantil force-pushed the e2e-live-iso-ssh-implementation/max branch from c312356 to 2fe5805 Compare November 21, 2023 13:15
@maxrantil
Copy link
Member Author

/metal3-bmo-e2e-test
/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@maxrantil
Copy link
Member Author

How I check if the node it booting from Live-ISO or not it with the help of the df -h cmd.
The two different outputs is:

When booting from a Live-ISO (loaded into memory), the output is as follows:

Filesystem                Size      Used Available Use% Mounted on
/dev                      1.9G         0      1.9G   0% /dev
tmpfs                     1.9G         0      1.9G   0% /dev/shm
tmpfs                     1.9G     88.0K      1.9G   0% /run

In this case, you will not see a root filesystem (/) associated with a disk like /dev/vda1. Instead, the primary filesystems are memory-based (tmpfs).

When booting from a normal ISO (booting from disk), the output includes a disk-based root filesystem:

Filesystem                Size      Used Available Use% Mounted on
/dev                      1.9G         0      1.9G   0% /dev
/dev/vda1                18.9G     43.2M     18.3G   0% /
tmpfs                     1.9G         0      1.9G   0% /dev/shm
tmpfs                     1.9G     88.0K      1.9G   0% /run

Here, /dev/vda1 represents the disk-based root filesystem, indicating a normal ISO boot.

By examining the df -h output, specifically looking for the presence or absence of a disk-based root filesystem, you can confirm the boot method of the node.

@mboukhalfa mboukhalfa changed the title 馃尡E2e live iso ssh implementation/max 馃尡E2e live iso ssh implementation Nov 21, 2023
lentzi90
lentzi90 reviewed Nov 22, 2023
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress!
The ssh check will be useful also in other tests!

test/e2e/live_iso_test.go Outdated Show resolved Hide resolved
test/e2e/live_iso_test.go Outdated Show resolved Hide resolved
test/e2e/live_iso_test.go Outdated Show resolved Hide resolved
test/e2e/common.go Outdated Show resolved Hide resolved
test/e2e/common.go Show resolved Hide resolved
test/e2e/common.go Outdated Show resolved Hide resolved
test/e2e/live_iso_test.go Outdated Show resolved Hide resolved
@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Nov 22, 2023
@maxrantil maxrantil force-pushed the e2e-live-iso-ssh-implementation/max branch 2 times, most recently from 16153cb to b1f6f2f Compare November 22, 2023 08:50
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Nov 22, 2023
@maxrantil maxrantil force-pushed the e2e-live-iso-ssh-implementation/max branch 2 times, most recently from 0868797 to f811712 Compare November 22, 2023 08:59
@maxrantil
Copy link
Member Author

/metal3-bmo-e2e-test

1 similar comment
@maxrantil
Copy link
Member Author

/metal3-bmo-e2e-test

@maxrantil
Copy link
Member Author

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@maxrantil maxrantil mentioned this pull request Nov 22, 2023
Closed
@maxrantil maxrantil force-pushed the e2e-live-iso-ssh-implementation/max branch from bccfa1e to a1335c0 Compare November 22, 2023 14:28
@maxrantil
Test live-ISO provisioning in e2e and confirm successful boot with ssh
111df80 
implementation

Signed-off-by: Max Rantil <max.rantil@est.tech>
@maxrantil maxrantil force-pushed the e2e-live-iso-ssh-implementation/max branch from a1335c0 to 111df80 Compare November 22, 2023 14:35
@maxrantil
Copy link
Member Author

/metal3-bmo-e2e-test

@maxrantil
Copy link
Member Author

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

lentzi90
lentzi90 reviewed Nov 23, 2023
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

test/e2e/live_iso_test.go
Comment on lines +105 to +107
User: "cirros",
Auth: []ssh.AuthMethod{
ssh.Password("gocubsgo"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for the future: We should make this configurable and also support ssh keys. However, I think it is good enough for now since the ssh check can be disabled if needed.
I think we should work on this in a separate PR where we also add the ssh check to the other provisioning test.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I can do an issue on it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created here

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2023
@maxrantil
Copy link
Member Author

/cc @kashifest @dtantsur @zaneb

kashifest
kashifest reviewed Dec 1, 2023
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2023
@metal3-io-bot metal3-io-bot merged commit 98b4dff into metal3-io:main Dec 1, 2023
16 checks passed
@metal3-io-bot metal3-io-bot deleted the e2e-live-iso-ssh-implementation/max branch December 1, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@adilGhaffarDev adilGhaffarDev adilGhaffarDev left review comments

@kashifest kashifest kashifest left review comments

@dtantsur dtantsur Awaiting requested review from dtantsur

@zaneb zaneb Awaiting requested review from zaneb

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test live-ISO i e2e
5 participants
@maxrantil @metal3-io-bot @lentzi90 @adilGhaffarDev @kashifest