Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.4] 馃尡 improve hack/verify-release.sh draft release note handling #1460

Merged
merged 1 commit into from Nov 27, 2023
Merged

[release-0.4] 馃尡 improve hack/verify-release.sh draft release note handling #1460

merged 1 commit into from Nov 27, 2023

Conversation

metal3-io-bot
Copy link
Contributor

This is an automated cherry-pick of #1459

/assign tuminoid

@tuminoid
improve hack/verify-release.sh draft release note handling
67c2314 
Github API does not allow fetching draft release notes by tag, only
by release id. Add the required code to fetch that, and also do not
bail out if it fails, just skip the tests that require the data.

Also fix osv-scanner exiting the script before printing the
vulnerabilities. It returns failure when vulns are found.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@metal3-io-bot metal3-io-bot mentioned this pull request Nov 27, 2023
Merged
@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 27, 2023
@tuminoid
Copy link
Member

/override test-centos-e2e-integration-release-1-5
/override test-ubuntu-integration-release-1-5
Save the trees.

@metal3-io-bot
Copy link
Contributor Author

@tuminoid: Overrode contexts on behalf of tuminoid: test-centos-e2e-integration-release-1-5, test-ubuntu-integration-release-1-5

In response to this:

/override test-centos-e2e-integration-release-1-5
/override test-ubuntu-integration-release-1-5
Save the trees.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid
Copy link
Member

/lgtm
/assign @kashifest

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023
@kashifest
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2023
@metal3-io-bot metal3-io-bot merged commit b4474e0 into metal3-io:release-0.4 Nov 27, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tuminoid tuminoid

@kashifest kashifest

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@metal3-io-bot @tuminoid @kashifest