Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃尡 Install golangci-lint directly instead of building it using go-modules #1522

Merged
merged 1 commit into from
Jan 18, 2024
Merged

馃尡 Install golangci-lint directly instead of building it using go-modules #1522

merged 1 commit into from
Jan 18, 2024

Conversation

kashifest
Copy link
Member

as a benefit we get rid of the hashicorp dependencies from hack/tools/go.mod.

@metal3-io-bot metal3-io-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 18, 2024
tuminoid
tuminoid reviewed Jan 18, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny nit.

Makefile Outdated Show resolved Hide resolved
@kashifest kashifest force-pushed the fix/golangcilint-install-kashif branch from 8764595 to 4936275 Compare January 18, 2024 10:19
@kashifest
Copy link
Member Author

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@kashifest
Copy link
Member Author

/metal3-bmo-e2e-test

@maxrantil
Copy link
Member

Whaow! That's a lot of cleaning up lines :) LGTM

tuminoid
tuminoid reviewed Jan 18, 2024
View reviewed changes
Makefile Show resolved Hide resolved
@kashifest
Install golangci-lint directly instead of building it using go-modules
d4f8c1d 
Signed-off-by: Kashif Khan <kashif.khan@est.tech>
@kashifest kashifest force-pushed the fix/golangcilint-install-kashif branch from 4936275 to d4f8c1d Compare January 18, 2024 11:01
@kashifest
Copy link
Member Author

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@kashifest
Copy link
Member Author

/metal3-bmo-e2e-test

lentzi90
lentzi90 reviewed Jan 18, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2024
@kashifest
Copy link
Member Author

/test-centos-e2e-integration-main

@kashifest
Copy link
Member Author

/metal3-bmo-e2e-test

@honza
Copy link
Member

honza commented Jan 18, 2024

This is great.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: honza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2024
@kashifest
Copy link
Member Author

/metal3-bmo-e2e-test

@metal3-io-bot metal3-io-bot merged commit 26b5e5a into metal3-io:main Jan 18, 2024
21 checks passed
@metal3-io-bot metal3-io-bot deleted the fix/golangcilint-install-kashif branch January 18, 2024 13:52
@kashifest
Copy link
Member Author

/cherry-pick release-0.5

@metal3-io-bot
Copy link
Contributor

@kashifest: new pull request created: #1601

In response to this:

/cherry-pick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot mentioned this pull request Mar 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@lentzi90 lentzi90 lentzi90 left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kashifest @maxrantil @honza @metal3-io-bot @tuminoid @lentzi90