Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Implement E2E_CONF_FILE Override in ci-e2e.sh #1526

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

maxrantil
Copy link
Member

What this PR does / why we need it:
Override the default E2E_CONF_FILE in ci-e2e.sh to fix the configuration issue in E2E tests after adding upgrade tests

…ests after adding upgrade tests.

Signed-off-by: Max Rantil <max.rantil@est.tech>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 22, 2024
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2024
@lentzi90
Copy link
Member

/test metal3-bmo-e2e-test-pull
Please check that this test is now using the correct config ☝️

@maxrantil
Copy link
Member Author

When reading the logs, I can with the help of these line confirm that the ironic.yaml file was used:

09:30:46    STEP: Verifying the node booting from disk @ 01/22/24 07:30:40.928
09:30:58    INFO: System is booted from a disk.

@maxrantil
Copy link
Member Author

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2024
@maxrantil
Copy link
Member Author

/test-centos-e2e-integration-main

@metal3-io-bot metal3-io-bot merged commit 8b412ce into metal3-io:main Jan 22, 2024
20 checks passed
@metal3-io-bot metal3-io-bot deleted the fix-e2e-config-override/max branch January 22, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants