Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Remove Inspector from all deployments scripts #1544

Merged
merged 3 commits into from Feb 29, 2024
Merged

⚠️ Remove Inspector from all deployments scripts #1544

merged 3 commits into from Feb 29, 2024

Conversation

dtantsur
Copy link
Member

@dtantsur dtantsur commented Feb 2, 2024

With this change, the scripts will no longer install ironic-inspector,
relying on the ironic's built-in inspection instead.

Note that BMO itself still supports Inspector as the inspection backend,
the change only affects deploy.sh and Kustomization configs.

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 2, 2024
@dtantsur
Copy link
Member Author

dtantsur commented Feb 2, 2024

/test-centos-e2e-integration-main
/test metal3-bmo-e2e-test-pull

@dtantsur
Copy link
Member Author

dtantsur commented Feb 2, 2024

/test metal3-bmo-e2e-test-pull

@kashifest
Copy link
Member

/test-centos-e2e-integration-main

1 similar comment
@kashifest
Copy link
Member

/test-centos-e2e-integration-main

@kashifest
Copy link
Member

I think for this to pass the centos tests, we need to get rid of some hard assumption on BMO kustomization on dev env side, I can see from the logs that BMO is complaining about "Could not contact ironic-inspector for version discovery: Unable to find a version discovery document at http://172.22.0.2:5050, the service is unavailable or misconfigured. Required version range (any - any), version hack disabled.","current":"inspect failed","target":"manageable" . Also I see this https://github.com/metal3-io/metal3-dev-env/blob/main/03_launch_mgmt_cluster.sh#L69 in dev-ev which we shouldnt need anymore after this PR right ?

@dtantsur
Copy link
Member Author

dtantsur commented Feb 5, 2024

metal3-io/metal3-dev-env#1346

@lentzi90
Copy link
Member

lentzi90 commented Feb 6, 2024

/test metal3-bmo-e2e-test-pull
/test-centos-e2e-integration-main

@lentzi90
Copy link
Member

lentzi90 commented Feb 6, 2024

I would also be interested in the optional tests
/test metal3-bmo-e2e-test-optional-pull

@dtantsur
Copy link
Member Author

dtantsur commented Feb 6, 2024

/test-centos-e2e-integration-main

Connectivity issues

@kashifest
Copy link
Member

I would also be interested in the optional tests /test metal3-bmo-e2e-test-optional-pull

This test is now trying to find /home/metal3ci/slave_root/workspace/metal3-bmo-e2e-test-optional-pull/config/overlays/e2e-release-0.4/ironic-inspector-username , so possibly deploying BMO from release-0.4 branch and upgrading to latest, so could it be that this PR needs to also make sure that when we deploy older branches the inspector configs are present?

@lentzi90
Copy link
Member

lentzi90 commented Feb 6, 2024

I would also be interested in the optional tests /test metal3-bmo-e2e-test-optional-pull

This test is now trying to find /home/metal3ci/slave_root/workspace/metal3-bmo-e2e-test-optional-pull/config/overlays/e2e-release-0.4/ironic-inspector-username , so possibly deploying BMO from release-0.4 branch and upgrading to latest, so could it be that this PR needs to also make sure that when we deploy older branches the inspector configs are present?

Yeah I think the issue is that ci-e2e.sh is generating credentials for both overlays (e2e and e2e-releas-0.4). The 0.4 overlay still needs them and fails when we do not generate them. Just leaving that part of the script as is should solve it.

lentzi90
lentzi90 reviewed Feb 6, 2024
View reviewed changes
hack/ci-e2e.sh Outdated Show resolved Hide resolved
@tuminoid tuminoid mentioned this pull request Feb 8, 2024
Merged
@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Feb 12, 2024
dtantsur added a commit to dtantsur/metal3-docs that referenced this pull request Feb 21, 2024
@dtantsur
User guide: updates for Inspector removal
66d44fc 
Depends on:
- metal3-io/baremetal-operator#1544

Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
@dtantsur dtantsur mentioned this pull request Feb 21, 2024
Merged
@dtantsur
Remove Inspector from all deployments scripts
9a014d4 
With this change, the scripts will no longer install ironic-inspector,
relying on the ironic's built-in inspection instead.

Note that BMO itself still supports Inspector as the inspection backend,
the change only affects deploy.sh and Kustomization configs.

Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Feb 21, 2024
@dtantsur
Copy link
Member Author

/test metal3-bmo-e2e-test-pull

@mquhuy
Copy link
Member

mquhuy commented Feb 21, 2024

Upgrade test is in the optional e2e test
/test metal3-bmo-e2e-test-optional-pull

@dtantsur
Copy link
Member Author

Huh, BMO is trying to mount the inspector credentials.. Which are not there.

@dtantsur
Still generate inspector credentials for BMO<=0.5
f84b315 
Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
@dtantsur
Copy link
Member Author

/test metal3-bmo-e2e-test-optional-pull

@dtantsur
Copy link
Member Author

/test metal3-bmo-e2e-test-pull
/test-centos-e2e-integration-main

@dtantsur
Copy link
Member Author

All passed \o/

mquhuy
mquhuy reviewed Feb 22, 2024
View reviewed changes
config/README.md Outdated Show resolved Hide resolved
@dtantsur
Fix a typo in config/README.md
ab394bd 
Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
@dtantsur
Copy link
Member Author

/test metal3-bmo-e2e-test-optional-pull
/test metal3-bmo-e2e-test-pull
/test-centos-e2e-integration-main

lentzi90
lentzi90 reviewed Feb 22, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2024
@dtantsur
Copy link
Member Author

/cc @kashifest @zaneb

Could either of you approve?

@zaneb
Copy link
Member

zaneb commented Feb 29, 2024

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2024
@metal3-io-bot metal3-io-bot merged commit 466bafc into metal3-io:main Feb 29, 2024
23 checks passed
@dtantsur dtantsur deleted the no-inspector branch February 29, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@mquhuy mquhuy mquhuy left review comments

@kashifest kashifest Awaiting requested review from kashifest

@zaneb zaneb Awaiting requested review from zaneb

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dtantsur @kashifest @lentzi90 @mquhuy @zaneb @metal3-io-bot