Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃尡 E2E: Remove unused variables #1557

Merged
merged 1 commit into from Feb 15, 2024
Merged

馃尡 E2E: Remove unused variables #1557

merged 1 commit into from Feb 15, 2024

Conversation

lentzi90
Copy link
Member

What this PR does / why we need it:

For legacy reasons, the configmaps used to configure BMO and Ironic were identical. The same configmap could then be used by both. This is not done in practice in the e2e tests so it does not make sense to keep BMO related variables in the configmap for Ironic and vice versa. This commit removes the irrelevant variables from the config files.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@lentzi90
E2E: Remove unused variables
58b1376 
For legacy reasons, the configmaps used to configure BMO and Ironic were
identical. The same configmap could then be used by both. This is not
done in practice in the e2e tests so it does not make sense to keep BMO
related variables in the configmap for Ironic and vice versa.
This commit removes the irrelevant variables from the config files.

Signed-off-by: Lennart Jern <lennart.jern@est.tech>
@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 14, 2024
@lentzi90
Copy link
Member Author

/test metal3-bmo-e2e-test-pull
/test metal3-bmo-e2e-optional-test-pull

@lentzi90
Copy link
Member Author

/test ?

@metal3-io-bot
Copy link
Contributor

@lentzi90: The following commands are available to trigger required jobs:

  • /test generate
  • /test gofmt
  • /test golint
  • /test gomod
  • /test gosec
  • /test manifestlint
  • /test markdownlint
  • /test metal3-bmo-e2e-test-pull
  • /test shellcheck
  • /test unit

The following commands are available to trigger optional jobs:

  • /test metal3-bmo-e2e-test-optional-pull

Use /test all to run the following jobs that were automatically triggered:

  • generate
  • gofmt
  • golint
  • gomod
  • gosec
  • manifestlint
  • unit

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lentzi90
Copy link
Member Author

/test metal3-bmo-e2e-test-optional-pull

@lentzi90
Copy link
Member Author

/test-centos-e2e-integration-main

4 similar comments
@lentzi90
Copy link
Member Author

/test-centos-e2e-integration-main

@lentzi90
Copy link
Member Author

/test-centos-e2e-integration-main

@tuminoid
Copy link
Member

/test-centos-e2e-integration-main

@tuminoid
Copy link
Member

/test-centos-e2e-integration-main

@mquhuy
Copy link
Member

mquhuy commented Feb 14, 2024

LGTM. This is a nice change!

@tuminoid
Copy link
Member

/test-centos-e2e-integration-main

1 similar comment
@lentzi90
Copy link
Member Author

/test-centos-e2e-integration-main

kashifest
kashifest reviewed Feb 14, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Good clean up, less confusion

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2024
@lentzi90
Copy link
Member Author

/test-centos-e2e-integration-main

@elfosardo
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2024
@metal3-io-bot metal3-io-bot merged commit 5dc5e5f into metal3-io:main Feb 15, 2024
19 of 20 checks passed
@metal3-io-bot metal3-io-bot deleted the lentzi90/remove-unused-vars branch February 15, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifest kashifest kashifest left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lentzi90 @metal3-io-bot @tuminoid @mquhuy @elfosardo @kashifest